Project

General

Profile

Feature #45934

mgr/dashboard: Use SASS's new Modules instead of the old @import

Added by Enno Gotthold 8 months ago. Updated 7 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Enno Gotthold
Category:
dashboard/UI
Target version:
Ceph - v16.0.0
% Done:

0%

Source:
Tags:
Backport:
Reviewed:
Affected Versions:
Pull request ID:
35501
Tags:
refactoring

Description

SASS recently announced its new module system (see: https://sass-lang.com/blog/the-module-system-is-launched). This means that of the 1st October 2022 most likely our code won't compile with the most up to date SASS version.

Related issues

Related to mgr - Bug #46869: mgr/dashboard: SCSS modules are breaking our current way of branding the dashboard Resolved

History

#1 Updated by Tiago Melo 8 months ago

I have tried to implement this on our code, but its currently not possible as bootstrap doesn't support it yet.
https://github.com/twbs/bootstrap/issues/29853

#2 Updated by Tiago Melo 7 months ago

  • Category set to dashboard/UI
  • Status changed from New to In Progress
  • Assignee set to Enno Gotthold

#3 Updated by Tiago Melo 7 months ago

  • Pull request ID set to 35501

#4 Updated by Tiago Melo 7 months ago

  • Subject changed from Use SASS's new Modules instead of the old @import to mgr/dashboard: Use SASS's new Modules instead of the old @import
  • Status changed from In Progress to Fix Under Review

#5 Updated by Lenz Grimmer 7 months ago

  • Tags set to refactoring
  • Status changed from Fix Under Review to Resolved
  • Target version set to v16.0.0

Thank you for you contribution, Enno!

#6 Updated by Alfonso Martínez 4 months ago

  • Related to Bug #46869: mgr/dashboard: SCSS modules are breaking our current way of branding the dashboard added

Also available in: Atom PDF