Project

General

Profile

Actions

Bug #45798

closed

librbd: make rbd_read_from_replica_policy actually work

Added by Ilya Dryomov almost 4 years ago. Updated almost 4 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
octopus
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

Neither rbd_read_from_replica_policy=balance nor rbd_read_from_replica_policy=localize actually work because wrong flags are set.


Related issues 1 (0 open1 closed)

Copied to rbd - Backport #45799: octopus: librbd: make rbd_read_from_replica_policy actually workResolvedNathan CutlerActions
Actions #1

Updated by Ilya Dryomov almost 4 years ago

  • Status changed from New to Fix Under Review
  • Pull request ID set to 35332
Actions #2

Updated by Ilya Dryomov almost 4 years ago

  • Backport set to octopus
Actions #3

Updated by Jason Dillaman almost 4 years ago

  • Status changed from Fix Under Review to Pending Backport
Actions #4

Updated by Nathan Cutler almost 4 years ago

  • Copied to Backport #45799: octopus: librbd: make rbd_read_from_replica_policy actually work added
Actions #5

Updated by Ilya Dryomov almost 4 years ago

Note that now that it actually works, we will hit #45795.

Actions #6

Updated by Jason Dillaman almost 4 years ago

Ilya Dryomov wrote:

Note that now that it actually works, we will hit #45795.

Is librbd marking notify ops w/ the read-from-replica flags?

Actions #7

Updated by Ilya Dryomov almost 4 years ago

It doesn't, disregard that.

The kernel client ends up marking them because read-from-replica is implemented in libceph, not in rbd.
Context switching is hard ;)

Actions #8

Updated by Nathan Cutler almost 4 years ago

  • Status changed from Pending Backport to Resolved

While running with --resolve-parent, the script "backport-create-issue" noticed that all backports of this issue are in status "Resolved" or "Rejected".

Actions

Also available in: Atom PDF