Project

General

Profile

Actions
Copy link

Bug #45723

closed

vstart_runner: LocalFuseMount.mount should set set.mounted to True

Added by Rishabh Dave almost 4 years ago. Updated almost 4 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Rishabh Dave
Category:
-
Target version:
Ceph - v16.0.0
% Done:

0%

Source:
Development
Tags:
Backport:
octopus,nautilus
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
qa-suite
Labels (FS):
qa
Pull request ID:
35267
Crash signature (v1):
Crash signature (v2):

Description

When not to set to True, the cleanup doesn't run on teardown since cleanup methods just exit when self.mounted is set to False. mount() in fuse_mount.py does set self.mounted to True; see - https://github.com/ceph/ceph/blob/master/qa/tasks/cephfs/fuse_mount.py#L171.

I did hit this issue while working on PR #32581. The issue is reported in this comment - https://github.com/ceph/ceph/pull/32581#issuecomment-634439541.

2020-05-26 16:51:36,283.283 INFO:__main__:
2020-05-26 16:51:36,283.283 INFO:__main__:======================================================================
2020-05-26 16:51:36,283.283 INFO:__main__:ERROR: test_rw (tasks.cephfs.test_multifs.TestCmdFsAuth)
2020-05-26 16:51:36,283.283 INFO:__main__:----------------------------------------------------------------------
2020-05-26 16:51:36,283.283 INFO:__main__:Traceback (most recent call last):
2020-05-26 16:51:36,283.283 INFO:__main__:  File "/home/rishabh/repos/ceph/master/qa/tasks/cephfs/test_multifs.py", line 48, in setUp
2020-05-26 16:51:36,283.283 INFO:__main__:    super(TestMultiFS, self).setUp()
2020-05-26 16:51:36,284.284 INFO:__main__:  File "/home/rishabh/repos/ceph/master/qa/tasks/cephfs/cephfs_test_case.py", line 171, in setUp
2020-05-26 16:51:36,284.284 INFO:__main__:    self.mounts[i].mount_wait()
2020-05-26 16:51:36,284.284 INFO:__main__:  File "/home/rishabh/repos/ceph/master/qa/tasks/cephfs/mount.py", line 384, in mount_wait
2020-05-26 16:51:36,284.284 INFO:__main__:    check_status=check_status)
2020-05-26 16:51:36,284.284 INFO:__main__:  File "../qa/tasks/vstart_runner.py", line 810, in mount
2020-05-26 16:51:36,284.284 INFO:__main__:    waited
2020-05-26 16:51:36,284.284 INFO:__main__:RuntimeError: Fuse mount failed to populate /sys/ after 31 seconds

Related issues 2 (0 open — 2 closed)

Copied to CephFS - Backport #45773: octopus: vstart_runner: LocalFuseMount.mount should set set.mounted to TrueResolvedNathan CutlerActions
Copied to CephFS - Backport #45774: nautilus: vstart_runner: LocalFuseMount.mount should set set.mounted to TrueResolvedNathan CutlerActions
Actions
Copy link
 #1

Updated by Rishabh Dave almost 4 years ago

  • Pull request ID set to 35267
Actions
Copy link
 #2

Updated by Rishabh Dave almost 4 years ago

  • Status changed from In Progress to Fix Under Review
Actions
Copy link
 #3

Updated by Patrick Donnelly almost 4 years ago

  • Target version set to v16.0.0
  • Source set to Development
  • Backport set to octopus,nautilus
Actions
Copy link
 #4

Updated by Patrick Donnelly almost 4 years ago

  • Status changed from Fix Under Review to Pending Backport
Actions
Copy link
 #5

Updated by Nathan Cutler almost 4 years ago

  • Copied to Backport #45773: octopus: vstart_runner: LocalFuseMount.mount should set set.mounted to True added
Actions
Copy link
 #6

Updated by Nathan Cutler almost 4 years ago

  • Copied to Backport #45774: nautilus: vstart_runner: LocalFuseMount.mount should set set.mounted to True added
Actions
Copy link
 #7

Updated by Nathan Cutler almost 4 years ago

  • Status changed from Pending Backport to Resolved

While running with --resolve-parent, the script "backport-create-issue" noticed that all backports of this issue are in status "Resolved" or "Rejected".

Actions
Copy link

Also available in: Atom PDF