Project

General

Profile

Actions

Bug #45714

closed

[rbd-mirror] ensure ops are canceled during replayer shut down before waiting

Added by Jason Dillaman almost 4 years ago. Updated almost 4 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Jason Dillaman
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
octopus
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

If rbd-mirror attempts to shut down its journal replayer, it might shut down after a op has started but before the OpFinish event is processed. In that case, the op will never finish and the wait-for-events state will never advance. This reverts to the pre-Octopus behavior prior to rbd-mirror being refactored.


Related issues 1 (0 open1 closed)

Copied to rbd - Backport #45885: octopus: [rbd-mirror] ensure ops are canceled during replayer shut down before waitingResolvedNathan CutlerActions
Actions #1

Updated by Jason Dillaman almost 4 years ago

  • Status changed from New to In Progress
  • Assignee set to Jason Dillaman
Actions #2

Updated by Jason Dillaman almost 4 years ago

  • Subject changed from Snapshot quiesce / unquiesce might stall librbd client shutdown to [rbd-mirror] ensure ops are canceled during replayer shut down before waiting
  • Description updated (diff)
  • Backport set to octopus
Actions #3

Updated by Jason Dillaman almost 4 years ago

  • Status changed from In Progress to Fix Under Review
  • Pull request ID set to 35348
Actions #4

Updated by Jason Dillaman almost 4 years ago

Note: backport to octopus should skip the first commit (the revert) but instead cherry-pick 4a23b4be68d00ac45216f7208ef19731006887da.

Actions #5

Updated by Mykola Golub almost 4 years ago

  • Status changed from Fix Under Review to Pending Backport
Actions #6

Updated by Nathan Cutler almost 4 years ago

  • Copied to Backport #45885: octopus: [rbd-mirror] ensure ops are canceled during replayer shut down before waiting added
Actions #7

Updated by Nathan Cutler almost 4 years ago

  • Status changed from Pending Backport to Resolved

While running with --resolve-parent, the script "backport-create-issue" noticed that all backports of this issue are in status "Resolved" or "Rejected".

Actions

Also available in: Atom PDF