Project

General

Profile

Bug #45458

non-ascii chars in /etc/prometheus/ceph/ceph_default_alerts.yml

Added by Michael Fritch 2 months ago. Updated about 1 month ago.

Status:
Resolved
Priority:
Urgent
Category:
cephadm
Target version:
% Done:

0%

Source:
Q/A
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature:

Description

http://qa-proxy.ceph.com/teuthology/mgfritch-2020-05-09_01:31:09-rados-wip-mgfritch-testing-2020-05-08-1646-distro-basic-smithi/5035782/teuthology.log

/etc/prometheus/ceph/ceph_default_alerts.yml contains non-ascii chars:

2020-05-09T02:04:02.183 INFO:ceph.mgr.y.smithi116.stdout:May 09 02:04:01 smithi116 bash[11525]: debug 2020-05-09T02:04:01.859+0000 7f66f658e700 -1 log_channel(cephadm) log [ERR] : Failed to apply prometheus spec ServiceSpec({'placement': PlacementSpec(count=1, hosts=[HostPlacementSpec(hostname='smithi095', network='', name='a')]), 'service_type': 'prometheus', 'service_id': None, 'unmanaged': False}): 'ascii' codec can't decode byte 0xe2 in position 2023: ordinal not in range(128)
2020-05-09T02:04:02.183 INFO:ceph.mgr.y.smithi116.stdout:May 09 02:04:01 smithi116 bash[11525]: Traceback (most recent call last):
2020-05-09T02:04:02.183 INFO:ceph.mgr.y.smithi116.stdout:May 09 02:04:01 smithi116 bash[11525]:   File "/usr/share/ceph/mgr/cephadm/module.py", line 1736, in _apply_all_services
2020-05-09T02:04:02.184 INFO:ceph.mgr.y.smithi116.stdout:May 09 02:04:01 smithi116 bash[11525]:     if self._apply_service(spec):
2020-05-09T02:04:02.184 INFO:ceph.mgr.y.smithi116.stdout:May 09 02:04:01 smithi116 bash[11525]:   File "/usr/share/ceph/mgr/cephadm/module.py", line 1707, in _apply_service
2020-05-09T02:04:02.184 INFO:ceph.mgr.y.smithi116.stdout:May 09 02:04:01 smithi116 bash[11525]:     create_func(daemon_id, host)  # type: ignore
2020-05-09T02:04:02.184 INFO:ceph.mgr.y.smithi116.stdout:May 09 02:04:01 smithi116 bash[11525]:   File "/usr/share/ceph/mgr/cephadm/services/monitoring.py", line 177, in create
2020-05-09T02:04:02.184 INFO:ceph.mgr.y.smithi116.stdout:May 09 02:04:01 smithi116 bash[11525]:     return self.mgr._create_daemon('prometheus', daemon_id, host)
2020-05-09T02:04:02.185 INFO:ceph.mgr.y.smithi116.stdout:May 09 02:04:01 smithi116 bash[11525]:   File "/usr/share/ceph/mgr/cephadm/module.py", line 1518, in _create_daemon
2020-05-09T02:04:02.185 INFO:ceph.mgr.y.smithi116.stdout:May 09 02:04:01 smithi116 bash[11525]:     cephadm_config, deps = self.prometheus_service.generate_config()
2020-05-09T02:04:02.185 INFO:ceph.mgr.y.smithi116.stdout:May 09 02:04:01 smithi116 bash[11525]:   File "/usr/share/ceph/mgr/cephadm/services/monitoring.py", line 267, in generate_config
2020-05-09T02:04:02.185 INFO:ceph.mgr.y.smithi116.stdout:May 09 02:04:01 smithi116 bash[11525]:     alerts = f.read()
2020-05-09T02:04:02.185 INFO:ceph.mgr.y.smithi116.stdout:May 09 02:04:01 smithi116 bash[11525]:   File "/lib64/python3.6/encodings/ascii.py", line 26, in decode
2020-05-09T02:04:02.186 INFO:ceph.mgr.y.smithi116.stdout:May 09 02:04:01 smithi116 bash[11525]:     return codecs.ascii_decode(input, self.errors)[0]
2020-05-09T02:04:02.186 INFO:ceph.mgr.y.smithi116.stdout:May 09 02:04:01 smithi116 bash[11525]: UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 2023: ordinal not in range(128)

non-ascii chars introduced:
https://github.com/ceph/ceph/commit/653c3f66823179fc5b9cbb74ff932d61a6c4178c

History

#1 Updated by Michael Fritch 2 months ago

  • Subject changed from non-ascii chars in monitoring to non-ascii chars in /etc/prometheus/ceph/ceph_default_alerts.yml

#2 Updated by Michael Fritch 2 months ago

  • Pull request ID set to 34977

#3 Updated by Sebastian Wagner 2 months ago

  • Source set to Q/A

#4 Updated by Sebastian Wagner 2 months ago

  • Priority changed from Normal to Urgent

#5 Updated by Sebastian Wagner 2 months ago

  • Status changed from In Progress to Pending Backport

#6 Updated by Sebastian Wagner about 1 month ago

  • Status changed from Pending Backport to Resolved
  • Target version set to v15.2.4

Also available in: Atom PDF