Project

General

Profile

Bug #45430

qa/cephfs: cleanup() and cleanup_netns() needs to be run even FS was not mounted

Added by Rishabh Dave 2 months ago. Updated about 2 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
% Done:

0%

Source:
Development
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
Labels (FS):
qa
Pull request ID:
Crash signature:

Description

Mountpoint directory and network namespaces are created whether or not the mount command itself passes. Therefore, both of these must be cleaned up when umount() or umount_wait() is called whether or not mount command itself succeeded. Following is traceback from a test in test_mutlifs.py run using vstart_runner.py -

2020-05-07 17:22:39,863.863 INFO:__main__:Traceback (most recent call last):
2020-05-07 17:22:39,863.863 INFO:__main__:  File "/home/rishabh/repos/ceph/multifs-auth/qa/tasks/cephfs/test_multifs.py", line 49, in setUp
2020-05-07 17:22:39,863.863 INFO:__main__:    super(TestMultiFS, self).setUp()
2020-05-07 17:22:39,864.864 INFO:__main__:  File "/home/rishabh/repos/ceph/multifs-auth/qa/tasks/cephfs/cephfs_test_case.py", line 171, in setUp
2020-05-07 17:22:39,864.864 INFO:__main__:    self.mounts[i].mount_wait()
2020-05-07 17:22:39,864.864 INFO:__main__:  File "/home/rishabh/repos/ceph/multifs-auth/qa/tasks/cephfs/mount.py", line 453, in mount_wait
2020-05-07 17:22:39,864.864 INFO:__main__:    check_status=check_status)
2020-05-07 17:22:39,864.864 INFO:__main__:  File "../qa/tasks/vstart_runner.py", line 726, in mount
2020-05-07 17:22:39,864.864 INFO:__main__:    self.setup_netns()
2020-05-07 17:22:39,864.864 INFO:__main__:  File "/home/rishabh/repos/ceph/multifs-auth/qa/tasks/cephfs/mount.py", line 412, in setup_netns
2020-05-07 17:22:39,864.864 INFO:__main__:    self._setup_netns()
2020-05-07 17:22:39,864.864 INFO:__main__:  File "/home/rishabh/repos/ceph/multifs-auth/qa/tasks/cephfs/mount.py", line 215, in _setup_netns
2020-05-07 17:22:39,864.864 INFO:__main__:    raise RuntimeError("the netns '{}' already exists!".format(self.netns_name))
2020-05-07 17:22:39,864.864 INFO:__main__:RuntimeError: the netns 'ceph-ns--tmp-tmpm6WZhO-mnt.0' already exists!

History

#1 Updated by Rishabh Dave 2 months ago

  • Pull request ID set to 34951

#2 Updated by Patrick Donnelly 2 months ago

  • Status changed from In Progress to Fix Under Review
  • Target version set to v16.0.0
  • Source set to Development

#3 Updated by Patrick Donnelly about 2 months ago

  • Status changed from Fix Under Review to Resolved

Also available in: Atom PDF