Project

General

Profile

Cleanup #45415

mgr/dashboard: test prometheus/alertmanager rules through promtool

Added by Ernesto Puerta almost 4 years ago. Updated almost 3 years ago.

Status:
Resolved
Priority:
High
Category:
Monitoring
Target version:
% Done:

0%

Tags:
Backport:
pacific,octopus,nautilus
Reviewed:
Affected Versions:
Pull request ID:

Description

Given the increasing number of issues found on monitoring, some validation/testing should be put in place to avoid manual/integration testing.

Fortunately Prometheus Alertmanager offers a tool (promtool) for generating fake timeseries and test rules with them: https://prometheus.io/docs/prometheus/latest/configuration/unit_testing_rules/.


Related issues

Related to Dashboard - Bug #45448: mgr/dashboard: automated tests for Prometheus configuration New
Related to Ceph - Bug #49695: install-deps: docker-ce, docker-ce-cli, containerd.io not found on f33 Closed
Copied to Dashboard - Backport #49656: nautilus: mgr/dashboard: test prometheus/alertmanager rules through promtool Resolved
Copied to Dashboard - Backport #49657: octopus: mgr/dashboard: test prometheus/alertmanager rules through promtool Resolved
Copied to Dashboard - Backport #49658: pacific: mgr/dashboard: test prometheus/alertmanager rules through promtool Resolved

History

#1 Updated by Ernesto Puerta almost 4 years ago

  • Related to Bug #45448: mgr/dashboard: automated tests for Prometheus configuration added

#2 Updated by Alfonso Martínez almost 4 years ago

Alertmanager also has its own tool to check its config:

amtool check-config <config.yml>

#3 Updated by Ernesto Puerta about 3 years ago

  • Tracker changed from Bug to Tasks

#4 Updated by Aashish Sharma about 3 years ago

  • Status changed from New to In Progress
  • Assignee set to Aashish Sharma
  • Pull request ID set to 39246

#5 Updated by Aashish Sharma about 3 years ago

  • Subject changed from mgr/dashboard: run alertmanager rules through promtool to mgr/dashboard: test prometheus/alertmanager rules through promtool

#6 Updated by Patrick Seidensal about 3 years ago

  • Status changed from In Progress to Fix Under Review

#7 Updated by Ernesto Puerta about 3 years ago

  • Tracker changed from Tasks to Cleanup
  • Status changed from Fix Under Review to Pending Backport
  • Backport set to pacific,octopus,nautilus

Given that we currently don't have any kind of testing covering alert rules, I'd suggest to backport this to all the maintained releases.

#8 Updated by Backport Bot about 3 years ago

  • Copied to Backport #49656: nautilus: mgr/dashboard: test prometheus/alertmanager rules through promtool added

#9 Updated by Backport Bot about 3 years ago

  • Copied to Backport #49657: octopus: mgr/dashboard: test prometheus/alertmanager rules through promtool added

#10 Updated by Backport Bot about 3 years ago

  • Copied to Backport #49658: pacific: mgr/dashboard: test prometheus/alertmanager rules through promtool added

#11 Updated by Brad Hubbard about 3 years ago

  • Status changed from Pending Backport to In Progress

Please don't backport this until the problems discussed in the most recent comments of https://github.com/ceph/ceph/pull/39246 have been worked through.

#12 Updated by Brad Hubbard about 3 years ago

  • Related to Bug #49695: install-deps: docker-ce, docker-ce-cli, containerd.io not found on f33 added

#13 Updated by Aashish Sharma about 3 years ago

  • Status changed from In Progress to Pending Backport

#14 Updated by Ernesto Puerta almost 3 years ago

  • Project changed from mgr to Dashboard
  • Category changed from 148 to Monitoring

#15 Updated by Ernesto Puerta almost 3 years ago

  • Status changed from Pending Backport to Resolved

Also available in: Atom PDF