Project

General

Profile

Actions

Cleanup #45321

closed

Servcie spec: unify `spec:` vs omitting `spec:`

Added by Sebastian Wagner almost 4 years ago. Updated almost 4 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
% Done:

0%

Tags:
Backport:
Reviewed:
Affected Versions:
Pull request ID:

Description

service_type: iscsi 
service_id: test
placement:
  hosts:
    - osd0
spec:
  pool: rbd
  api_user: admin
  api_password: admin
  trusted_ip_list: 192.168.121.1
service_type: iscsi 
service_id: test
placement:
  hosts:
    - osd0
pool: rbd
api_user: admin
api_password: admin
trusted_ip_list: 192.168.121.1

are the same data. we should unify them to one or the other.

This is is especially relevant for OSD specs.

Actions #1

Updated by Sebastian Wagner almost 4 years ago

decison was to use spec

Actions #2

Updated by Sebastian Wagner almost 4 years ago

  • Status changed from New to Fix Under Review
  • Pull request ID set to 35537
Actions #3

Updated by Sebastian Wagner almost 4 years ago

  • Status changed from Fix Under Review to Resolved
  • Target version set to v15.2.5
Actions

Also available in: Atom PDF