Project

General

Profile

Cleanup #45321

Servcie spec: unify `spec:` vs omitting `spec:`

Added by Sebastian Wagner 7 months ago. Updated 4 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
% Done:

0%

Tags:
Backport:
Reviewed:
Affected Versions:
Pull request ID:

Description

service_type: iscsi 
service_id: test
placement:
  hosts:
    - osd0
spec:
  pool: rbd
  api_user: admin
  api_password: admin
  trusted_ip_list: 192.168.121.1
service_type: iscsi 
service_id: test
placement:
  hosts:
    - osd0
pool: rbd
api_user: admin
api_password: admin
trusted_ip_list: 192.168.121.1

are the same data. we should unify them to one or the other.

This is is especially relevant for OSD specs.

History

#1 Updated by Sebastian Wagner 6 months ago

decison was to use spec

#2 Updated by Sebastian Wagner 6 months ago

  • Status changed from New to Fix Under Review
  • Pull request ID set to 35537

#3 Updated by Sebastian Wagner 4 months ago

  • Status changed from Fix Under Review to Resolved
  • Target version set to v15.2.5

Also available in: Atom PDF