Project

General

Profile

Feature #45263

osdspec/drivegroup: not enough filters to define layout

Added by Joshua Schmid 6 months ago. Updated 3 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
cephadm/osd
Target version:
% Done:

0%

Source:
Tags:
Backport:
Reviewed:
Affected Versions:
Pull request ID:

Description

Considering this layout:


Device Path               Size         rotates available Model name
/dev/nvme0n1              349.32 GB    False   True      INTEL SSDPED1K375GA <- db/wal
/dev/sdb                  1.82 TB      True    True      ST2000DM001-1ER1    <- data
/dev/sdc                  1.82 TB      True    True      ST2000DM001-1ER1    <- data
/dev/sdd                  1.82 TB      True    True      ST2000DM001-1ER1    <- data
/dev/sde                  1.82 TB      True    True      ST2000DM001-1ER1    <- data
/dev/sdf                  1.82 TB      True    True      ST2000DM001-1ER1    <- data
/dev/sdg                  223.57 GB    False   True      INTEL SSDSC2KG24    <- data
/dev/sdh                  223.57 GB    False   True      INTEL SSDSC2KG24    <- data
/dev/sda                  223.57 GB    False   False     SAMSUNG MZ7LM240

With the switch from wiring up the filters with OR to AND gates, this very scenario got impossible to describe with the available filters.
This would be theoretically possible with the usage of `slots`. But those are not implemented.

Consider this issue as a leaflet to implement slots or add a new filter like device_id.


Related issues

Related to Orchestrator - Bug #45861: data_devices: limit 3 deployed 6 osds per node Fix Under Review

History

#1 Updated by Sebastian Wagner 5 months ago

  • Related to Bug #45861: data_devices: limit 3 deployed 6 osds per node added

#2 Updated by Sebastian Wagner 4 months ago

  • Assignee set to Joshua Schmid

#3 Updated by Joshua Schmid 4 months ago

This patch allows to switch between `AND` and `OR` gating. https://github.com/ceph/ceph/compare/master...jschmid1:drivegroup_extension

While I don't like the approach, it's not the worst idea to be backwards compatible. DriveGroups that existed pre-cephadm were using `OR` gates exclusively. If we fully support adoptions we have to make sure to support the old behavior. Otherwise we'll probably end up a bad spot.

#4 Updated by Sebastian Wagner 4 months ago

  • Status changed from New to In Progress

#5 Updated by Joshua Schmid 4 months ago

  • Pull request ID set to 35916

#6 Updated by Joshua Schmid 4 months ago

  • Status changed from In Progress to Fix Under Review

#7 Updated by Sebastian Wagner 3 months ago

  • Category changed from cephadm to cephadm/osd

#8 Updated by Sebastian Wagner 3 months ago

  • Status changed from Fix Under Review to Pending Backport

#9 Updated by Sebastian Wagner 3 months ago

  • Status changed from Pending Backport to Resolved
  • Target version set to v15.2.5

Also available in: Atom PDF