Project

General

Profile

Bug #45249

cephadm: fail to apply a iSCSI ServiceSpec

Added by Kiefer Chang 5 months ago. Updated 4 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
cephadm
Target version:
% Done:

0%

Source:
Tags:
Backport:
octopus
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature:

Description

How to reproduce:
  • Create a spec file
    # cat /tmp/iscsi.txt 
    service_type: iscsi 
    service_id: test
    placement:
      hosts:
        - osd0
    spec:
      pool: rbd
      api_user: admin
      api_password: admin
      trusted_ip_list: 192.168.121.1
    
    
  • Apply it
    # bin/ceph orch apply -i /tmp/iscsi.txt                                              
    *** DEVELOPER MODE: setting PATH, PYTHONPATH and LD_LIBRARY_PATH ***
    2020-04-24T06:42:35.315+0000 7fa50e332700 -1 WARNING: all dangerous and experimental features are enabled.
    2020-04-24T06:42:35.343+0000 7fa50e332700 -1 WARNING: all dangerous and experimental features are enabled.
    Error ENOENT: ServiceSpec: __init__() missing 1 required positional argument: 'service_id
    

This can be fixed by adding iscsi to the check list here: https://github.com/ceph/ceph/blob/036c40e9432deafb4379cedb5c119109376cc5b9/src/pybind/mgr/cephadm/module.py#L2531


Related issues

Related to Orchestrator - Bug #45198: cephadm: unable to add iSCSI daemon from service spec yaml file Closed

History

#1 Updated by Kiefer Chang 5 months ago

  • Related to Bug #45198: cephadm: unable to add iSCSI daemon from service spec yaml file added

#2 Updated by Ricardo Marques 5 months ago

@Kiefer isn't this PR already fixing the issue? https://github.com/ceph/ceph/pull/34663

#3 Updated by Kiefer Chang 5 months ago

Ricardo Marques wrote:

@Kiefer isn't this PR already fixing the issue? https://github.com/ceph/ceph/pull/34663

Yes. I think it can fix this issue too!

#4 Updated by Michael Fritch 5 months ago

  • Pull request ID set to 34814

#5 Updated by Michael Fritch 5 months ago

  • Status changed from New to Fix Under Review

#6 Updated by Sebastian Wagner 5 months ago

  • Status changed from Fix Under Review to Pending Backport

#7 Updated by Sebastian Wagner 4 months ago

  • Status changed from Pending Backport to Resolved
  • Target version changed from v16.0.0 to v15.2.4

Also available in: Atom PDF