Bug #45198: cephadm: unable to add iSCSI daemon from service spec yaml file - Orchestrator - Ceph

Actions

Copy link

Bug #45198

closed

cephadm: unable to add iSCSI daemon from service spec yaml file

Added by Ricardo Marques about 4 years ago. Updated almost 4 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Matthew Oliver

Category:

cephadm

Target version:

% Done:

Source:

Tags:

Backport:

octopus

Regression:

Severity:

3 - minor

Reviewed:

Affected Versions:

ceph-qa-suite:

Pull request ID:

34722

Crash signature (v1):

Crash signature (v2):

Description

Looking into the docs [1], I see that we can use the `add` command in two different ways:

1) ceph orch daemon add iscsi -i <json_file>

2) ceph orch daemon add iscsi <pool>

but apparently the first one is not working as expected:

node1:~ # ceph orch daemon add iscsi -i iscsi.yaml 
Invalid command: missing required parameter pool(<string>)
orch daemon add iscsi <pool> [<fqdn_enabled>] [<trusted_ip_list>] [<placement>] :  Start iscsi daemon(s)
Error EINVAL: invalid command

node1:~ # ceph orch daemon add iscsi rbd -i iscsi.yaml 
Error EINVAL: Failed to read JSON input: Expecting value: line 1 column 1 (char 0)
        Usage:
          ceph orch daemon add iscsi -i <json_file>
          ceph orch daemon add iscsi <pool>

We should fix the command, or the documentation if it's not supposed to use the `-i` option.

[1] https://github.com/ceph/ceph/blob/master/src/pybind/mgr/orchestrator/module.py#L738

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by Matthew Oliver almost 4 years ago

Status changed from New to In Progress
Assignee set to Matthew Oliver
Pull request ID set to 34722

I've pushed a PR to fix this. And with this PR managed to deploy using the follow json:

{                                                                                                                                                                                                                                             
  "service_id": "iscsi",
  "pool": "iscsi",
  "trusted_ip_list": null,
  "fqdn_enabled": null,
  "api_port": null,
  "api_user": null,
  "api_password": null,
  "api_secure": null,
  "ssl_cert": null,
  "ssl_key": null,
  "service_type": "iscsi",
  "placement": {
    "hosts": [{
      "hostname": "ironic-moliver",
      "name": "",
      "network": "" 
    }],
    "count": 1
  },
  "unmanaged": false
}