Project

General

Profile

Bug #45174

cephadm: missing parameters on 'orch daemon add iscsi'

Added by Ricardo Marques 5 months ago. Updated 4 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Matthew Oliver
Category:
cephadm
Target version:
Ceph - v15.2.4
% Done:

0%

Source:
Tags:
Backport:
octopus
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
35097
Crash signature:

Description

`orch daemon add iscsi` is missing some parameters when compared to iSCSI service spec:

add command parameter: https://github.com/ceph/ceph/blob/master/src/pybind/mgr/orchestrator/module.py#L741

iscsi service spec: https://github.com/ceph/ceph/blob/master/src/python-common/ceph/deployment/service_spec.py#L575

Related issues

Duplicated by Orchestrator - Bug #45258: cephadm: iSCSIServiceSpec: user/password should be mandatory (or autogenerated) Duplicate

History

#1 Updated by Ricardo Marques 5 months ago

  • Category set to cephadm

#2 Updated by Sebastian Wagner 5 months ago

  • Status changed from New to Triaged

#3 Updated by Ricardo Marques 5 months ago

  • Subject changed from cephadm: missing parameter on 'orch daemon add iscsi' to cephadm: missing parameters on 'orch daemon add iscsi'

#4 Updated by Ricardo Marques 5 months ago

  • Assignee deleted (Ricardo Marques)

#5 Updated by Matthew Oliver 5 months ago

Isn't that normal. Others do that too, look at _add_rgw above it. if you want to set the non-standard options you are suppose to use the `-i <json>` approach. At least that was my understanding.

However, if we want to add all options to the commandline, then this can also be done.

#6 Updated by Ricardo Marques 5 months ago

Can we access ceph-iscsi API if we don't specify an `api_user` and `api_pass`?

#7 Updated by Sebastian Wagner 5 months ago

  • Duplicated by Bug #45258: cephadm: iSCSIServiceSpec: user/password should be mandatory (or autogenerated) added

#8 Updated by Matthew Oliver 5 months ago

  • Assignee set to Matthew Oliver

hrm, yeah good question. Any preferences? We could auto gen if not supplied and then something like `ceph orch ls --export` and cephadm enter to get the username and password, just use a default, or enforce a username and password.

Either way I'll have a play.

#9 Updated by Matthew Oliver 5 months ago

I've created a PR (https://github.com/ceph/ceph/pull/35097) that makes the api_user and api_password manditory.

#10 Updated by Sebastian Wagner 4 months ago

  • Status changed from Triaged to Fix Under Review
  • Target version deleted (v16.0.0)
  • Pull request ID set to 35097

#11 Updated by Sebastian Wagner 4 months ago

  • Status changed from Fix Under Review to Resolved
  • Target version set to v15.2.4

Also available in: Atom PDF