Bug #45174
closedcephadm: missing parameters on 'orch daemon add iscsi'
0%
Description
`orch daemon add iscsi` is missing some parameters when compared to iSCSI service spec:
add command parameter: https://github.com/ceph/ceph/blob/master/src/pybind/mgr/orchestrator/module.py#L741
iscsi service spec: https://github.com/ceph/ceph/blob/master/src/python-common/ceph/deployment/service_spec.py#L575
Updated by Sebastian Wagner about 4 years ago
- Status changed from New to Triaged
Updated by Ricardo Marques about 4 years ago
- Subject changed from cephadm: missing parameter on 'orch daemon add iscsi' to cephadm: missing parameters on 'orch daemon add iscsi'
Updated by Matthew Oliver about 4 years ago
Isn't that normal. Others do that too, look at _add_rgw above it. if you want to set the non-standard options you are suppose to use the `-i <json>` approach. At least that was my understanding.
However, if we want to add all options to the commandline, then this can also be done.
Updated by Ricardo Marques about 4 years ago
Can we access ceph-iscsi API if we don't specify an `api_user` and `api_pass`?
Updated by Sebastian Wagner almost 4 years ago
- Has duplicate Bug #45258: cephadm: iSCSIServiceSpec: user/password should be mandatory (or autogenerated) added
Updated by Matthew Oliver almost 4 years ago
- Assignee set to Matthew Oliver
hrm, yeah good question. Any preferences? We could auto gen if not supplied and then something like `ceph orch ls --export` and cephadm enter to get the username and password, just use a default, or enforce a username and password.
Either way I'll have a play.
Updated by Matthew Oliver almost 4 years ago
I've created a PR (https://github.com/ceph/ceph/pull/35097) that makes the api_user and api_password manditory.
Updated by Sebastian Wagner almost 4 years ago
- Status changed from Triaged to Fix Under Review
- Target version deleted (
v16.0.0) - Pull request ID set to 35097
Updated by Sebastian Wagner almost 4 years ago
- Status changed from Fix Under Review to Resolved
- Target version set to v15.2.4