Actions
Cleanup #45156
closedmgr/dashboard: Refactor Python unittests and controller
Status:
Resolved
Priority:
Normal
Assignee:
Category:
General - Back-end
Target version:
% Done:
0%
Tags:
Backport:
nautilus
Reviewed:
Affected Versions:
Pull request ID:
Description
- Make use of the KVStoreMockMixin class to get rid off duplicate code.
- Fake the index.html file to be able to run tests/test_home.py locally without building the frontend in production mode.
- Encapsulate helper functions in controllers/home.py, otherwise tests/test_feature_toggles.py need to fake the filesystem because load_controllers() will load the home.py controller and fail due missing files in the filesystem.
This issue is opened retrospectively to be able to backport it to Nautilus using the usual backport workflow.
Updated by Volker Theile about 4 years ago
- Status changed from New to Pending Backport
Updated by Volker Theile about 4 years ago
- Copied to Backport #45157: nautilus: mgr/dashboard: Refactor Python unittests and controller added
Updated by Kefu Chai almost 4 years ago
- Status changed from Pending Backport to Resolved
Updated by Ernesto Puerta about 3 years ago
- Project changed from mgr to Dashboard
- Category changed from 146 to General - Back-end
Actions