Project

General

Profile

Cleanup #45156

mgr/dashboard: Refactor Python unittests and controller

Added by Volker Theile 6 months ago. Updated 6 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
dashboard/backend
Target version:
% Done:

0%

Tags:
Backport:
nautilus
Reviewed:
Affected Versions:
Pull request ID:

Description

  • Make use of the KVStoreMockMixin class to get rid off duplicate code.
  • Fake the index.html file to be able to run tests/test_home.py locally without building the frontend in production mode.
  • Encapsulate helper functions in controllers/home.py, otherwise tests/test_feature_toggles.py need to fake the filesystem because load_controllers() will load the home.py controller and fail due missing files in the filesystem.

This issue is opened retrospectively to be able to backport it to Nautilus using the usual backport workflow.


Related issues

Copied to mgr - Backport #45157: nautilus: mgr/dashboard: Refactor Python unittests and controller Resolved

History

#1 Updated by Volker Theile 6 months ago

  • Status changed from New to Pending Backport

#2 Updated by Volker Theile 6 months ago

  • Copied to Backport #45157: nautilus: mgr/dashboard: Refactor Python unittests and controller added

#3 Updated by Kefu Chai 6 months ago

  • Status changed from Pending Backport to Resolved

Also available in: Atom PDF