Project

General

Profile

Bug #45071

cephfs-shell: CI testing does not detect flake8 errors

Added by Varsha Rao 8 months ago. Updated 5 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Code Hygiene
Target version:
% Done:

0%

Source:
Development
Tags:
Backport:
octopus
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
cephfs-shell
Labels (FS):
Pull request ID:
Crash signature:

Description

On explicitly passing py3 to envlist in CI testing, flake8 errors are not detected.

[root@localhost cephfs]# tox
flake8 installed: entrypoints==0.3,flake8==3.7.9,mccabe==0.6.1,pycodestyle==2.5.0,pyflakes==2.1.1
flake8 run-test-pre: PYTHONHASHSEED='2465495138'
flake8 runtests: commands[0] | flake8 --ignore=W503 --max-line-length=100 cephfs-shell
cephfs-shell:67:1: E302 expected 2 blank lines, found 1
cephfs-shell:114:78: E502 the backslash is redundant between brackets
cephfs-shell:121:1: E302 expected 2 blank lines, found 1
cephfs-shell:137:1: E302 expected 2 blank lines, found 1
cephfs-shell:1135:48: E226 missing whitespace around arithmetic operator
cephfs-shell:1140:40: E226 missing whitespace around arithmetic operator
cephfs-shell:1223:25: E128 continuation line under-indented for visual indent
cephfs-shell:1357:30: F821 undefined name 'e'
cephfs-shell:1402:57: W605 invalid escape sequence '\A'
cephfs-shell:1404:25: E128 continuation line under-indented for visual indent
cephfs-shell:1405:25: E128 continuation line under-indented for visual indent
cephfs-shell:1406:25: E128 continuation line under-indented for visual indent
cephfs-shell:1407:25: E122 continuation line missing indentation or outdented
cephfs-shell:1488:5: F841 local variable 'e' is assigned to but never used
cephfs-shell:1495:1: E302 expected 2 blank lines, found 1
cephfs-shell:1507:1: E302 expected 2 blank lines, found 1
cephfs-shell:1509:57: E502 the backslash is redundant between brackets
cephfs-shell:1510:13: E128 continuation line under-indented for visual indent
cephfs-shell:1511:62: E502 the backslash is redundant between brackets
cephfs-shell:1512:13: E128 continuation line under-indented for visual indent
cephfs-shell:1514:71: E502 the backslash is redundant between brackets
cephfs-shell:1515:13: E128 continuation line under-indented for visual indent
cephfs-shell:1518:70: E502 the backslash is redundant between brackets
cephfs-shell:1519:13: E128 continuation line under-indented for visual indent
cephfs-shell:1520:72: E502 the backslash is redundant between brackets
cephfs-shell:1521:13: E128 continuation line under-indented for visual indent
cephfs-shell:1529:1: E305 expected 2 blank lines after class or function definition, found 1
cephfs-shell:1551:45: E222 multiple spaces after operator
ERROR: InvocationError for command '/home/varsha/ceph/src/tools/cephfs/.tox/flake8/bin/flake8 --ignore=W503 --max-line-length=100 cephfs-shell' (exited with code 1)
__________________________________________________________________________________________________________________ summary ___________________________________________________________________________________________________________________
ERROR:   flake8: commands failed
[root@localhost cephfs]# tox -e py3
py3 recreate: /home/varsha/ceph/src/tools/cephfs/.tox/py3
py3 run-test-pre: PYTHONHASHSEED='2680249521'
__________________________________________________________________________________________________________________ summary ___________________________________________________________________________________________________________________
  py3: commands succeeded
  congratulations :)

Related issues

Copied to CephFS - Backport #45476: octopus: cephfs-shell: CI testing does not detect flake8 errors Resolved

History

#1 Updated by Varsha Rao 8 months ago

  • Status changed from In Progress to Fix Under Review
  • Pull request ID set to 34536

#2 Updated by Patrick Donnelly 7 months ago

  • Status changed from Fix Under Review to Pending Backport
  • Backport set to octopus

#3 Updated by Nathan Cutler 7 months ago

  • Copied to Backport #45476: octopus: cephfs-shell: CI testing does not detect flake8 errors added

#4 Updated by Nathan Cutler 5 months ago

  • Status changed from Pending Backport to Resolved

While running with --resolve-parent, the script "backport-create-issue" noticed that all backports of this issue are in status "Resolved" or "Rejected".

Also available in: Atom PDF