Project

General

Profile

Actions

Bug #44949

closed

simple/scan.py: syntax problem in log statement

Added by Jan Fajerski about 4 years ago. Updated almost 4 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
octopus,nautilus, mimic
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

A multiline string became a tuple due to superfluous comma.

('foo',
 'bar').format() # wrong!

instead of

('foo'
 'bar').format()
File "/usr/sbin/ceph-volume", line 9, in <module>
    load_entry_point('ceph-volume==1.0.0', 'console_scripts', 'ceph-volume')()
  File "/usr/lib/python2.7/dist-packages/ceph_volume/main.py", line 39, in __init__
    self.main(self.argv)
  File "/usr/lib/python2.7/dist-packages/ceph_volume/decorators.py", line 59, in newfunc
    return f(*a, **kw)
  File "/usr/lib/python2.7/dist-packages/ceph_volume/main.py", line 150, in main
    terminal.dispatch(self.mapper, subcommand_args)
  File "/usr/lib/python2.7/dist-packages/ceph_volume/terminal.py", line 194, in dispatch
    instance.main()
  File "/usr/lib/python2.7/dist-packages/ceph_volume/devices/simple/main.py", line 33, in main
    terminal.dispatch(self.mapper, self.argv)
  File "/usr/lib/python2.7/dist-packages/ceph_volume/terminal.py", line 194, in dispatch
    instance.main()
  File "/usr/lib/python2.7/dist-packages/ceph_volume/devices/simple/scan.py", line 381, in main
    self.scan(args)
  File "/usr/lib/python2.7/dist-packages/ceph_volume/decorators.py", line 16, in is_root
    return func(*a, **kw)
  File "/usr/lib/python2.7/dist-packages/ceph_volume/devices/simple/scan.py", line 250, in scan
    osd_metadata = self.scan_encrypted(osd_path)
  File "/usr/lib/python2.7/dist-packages/ceph_volume/devices/simple/scan.py", line 199, in scan_encrypted
    osd_metadata = self.scan_directory(directory)
  File "/usr/lib/python2.7/dist-packages/ceph_volume/devices/simple/scan.py", line 107, in scan_directory
    'suffix').format(file_))
AttributeError: 'tuple' object has no attribute 'format'

Related issues 3 (0 open3 closed)

Copied to ceph-volume - Backport #44973: mimic: simple/scan.py: syntax problem in log statementResolvedJan FajerskiActions
Copied to ceph-volume - Backport #44974: nautilus: simple/scan.py: syntax problem in log statementResolvedJan FajerskiActions
Copied to ceph-volume - Backport #44975: octopus: simple/scan.py: syntax problem in log statementResolvedJan FajerskiActions
Actions #1

Updated by Jan Fajerski about 4 years ago

  • Status changed from New to Fix Under Review
  • Pull request ID set to 34412
Actions #2

Updated by Jan Fajerski about 4 years ago

  • Status changed from Fix Under Review to Pending Backport
Actions #3

Updated by Jan Fajerski about 4 years ago

  • Copied to Backport #44973: mimic: simple/scan.py: syntax problem in log statement added
Actions #4

Updated by Jan Fajerski about 4 years ago

  • Copied to Backport #44974: nautilus: simple/scan.py: syntax problem in log statement added
Actions #5

Updated by Jan Fajerski about 4 years ago

  • Copied to Backport #44975: octopus: simple/scan.py: syntax problem in log statement added
Actions #6

Updated by Nathan Cutler almost 4 years ago

  • Status changed from Pending Backport to Resolved

While running with --resolve-parent, the script "backport-create-issue" noticed that all backports of this issue are in status "Resolved" or "Rejected".

Actions

Also available in: Atom PDF