Project

General

Profile

Feature #44783

c-v's batch report doesn't show if the disk is going to be encrypted

Added by Joshua Schmid over 2 years ago. Updated about 2 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Target version:
% Done:

0%

Source:
Development
Tags:
Backport:
Reviewed:
Affected Versions:
Pull request ID:

Description

/usr/sbin/ceph-volume lvm batch --no-auto /dev/vdb --dmcrypt --report --format json

gives

{
    "changed": true,
    "osds": [
        {
            "block.db": {},
            "data": {
                "human_readable_size": "24.00 GB",
                "parts": 1,
                "path": "/dev/vdb",
                "percentage": 100.0,
                "size": 24
            }
        }
    ],
    "vgs": []
}

which is missing the `encrypted` flag.


Related issues

Related to Orchestrator - Feature #44625: cephadm: test dmcrypt Resolved

History

#1 Updated by Jan Fajerski over 2 years ago

  • Subject changed from c-v's report doesn't show if the disk is going to be encrypted to c-v's batch report doesn't show if the disk is going to be encrypted

#2 Updated by Jan Fajerski over 2 years ago

  • Tracker changed from Bug to Feature

Changing this to a feature.

I'd like input on what you'd expect. An encrypted, but where? Under the 'data' key, under the OSD key? Should be be false in case of unencrypted or missing?

I'd propose an new 'encrypted' key under 'data' that is either false or true.

#3 Updated by Joshua Schmid over 2 years ago

I assume that --dmcrypt is a block key that will affect all provided disks.
If that's the case, it would suffice to put it one layer above, on the same level as "changed" and "osds"

I don't know how c-v treat external db/wals when this flag is provided. If these LVs are not encrypted we might be better off, being more granular by putting it into the 'data' struct.

#4 Updated by Kiefer Chang over 2 years ago

#5 Updated by Jan Fajerski about 2 years ago

  • Status changed from New to Resolved
  • Pull request ID set to 34740

Also available in: Atom PDF