Project

General

Profile

Actions

Bug #44657

closed

cephfs-shell: Fix flake8 errors (F841, E302, E502, E128, E305 and E222)

Added by Varsha Rao about 4 years ago. Updated almost 4 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
Code Hygiene
Target version:
% Done:

0%

Source:
Development
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
cephfs-shell
Labels (FS):
task(easy)
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

# flake8 --ignore=W503 --max-line-length=100 ../src/tools/cephfs/cephfs-shell
../src/tools/cephfs/cephfs-shell:1488:5: F841 local variable 'e' is assigned to but never used
../src/tools/cephfs/cephfs-shell:1495:1: E302 expected 2 blank lines, found 1
../src/tools/cephfs/cephfs-shell:1507:1: E302 expected 2 blank lines, found 1
../src/tools/cephfs/cephfs-shell:1509:57: E502 the backslash is redundant between brackets
../src/tools/cephfs/cephfs-shell:1510:13: E128 continuation line under-indented for visual indent
../src/tools/cephfs/cephfs-shell:1511:62: E502 the backslash is redundant between brackets
../src/tools/cephfs/cephfs-shell:1512:13: E128 continuation line under-indented for visual indent
../src/tools/cephfs/cephfs-shell:1514:71: E502 the backslash is redundant between brackets
../src/tools/cephfs/cephfs-shell:1515:13: E128 continuation line under-indented for visual indent
../src/tools/cephfs/cephfs-shell:1518:70: E502 the backslash is redundant between brackets
../src/tools/cephfs/cephfs-shell:1519:13: E128 continuation line under-indented for visual indent
../src/tools/cephfs/cephfs-shell:1520:72: E502 the backslash is redundant between brackets
../src/tools/cephfs/cephfs-shell:1521:13: E128 continuation line under-indented for visual indent
../src/tools/cephfs/cephfs-shell:1529:1: E305 expected 2 blank lines after class or function definition, found 1
../src/tools/cephfs/cephfs-shell:1551:45: E222 multiple spaces after operator
Actions #1

Updated by Varsha Rao about 4 years ago

  • Status changed from New to Fix Under Review
  • Pull request ID set to 34121
Actions #2

Updated by Greg Farnum almost 4 years ago

  • Status changed from Fix Under Review to Resolved
Actions #3

Updated by Varsha Rao almost 4 years ago

  • Status changed from Resolved to Pending Backport
  • Backport set to octopus
Actions #5

Updated by Nathan Cutler almost 4 years ago

  • Status changed from Pending Backport to Resolved
  • Backport deleted (octopus)
Actions

Also available in: Atom PDF