Project

General

Profile

Actions
Copy link

Bug #44610

closed

[python] ensure image is open before permitting operations

Added by Jason Dillaman about 4 years ago. Updated almost 4 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Mykola Golub
Target version:
-
% Done:

0%

Source:
Community (user)
Tags:
Backport:
nautilus,octopus
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
34112
Crash signature (v1):
Crash signature (v2):

Description

We have faced a bug in openstack-cinder when unprotect_snap() method was called for closed image object. As a result, SEGFAULT from python-rbd causes cinder-volume to crash.

I am not challenging the idea that unprotect_snap() method shouldn't be called for closed volume and that python-rbd should generate some form of exception. But IMO Segmentation fault is wrong way to handle such situations.

Version-Release number of selected component (if applicable):

This issue was there for a long time. We reproduced it for:
librbd1-12.2.12-74.el7cp.x86_64
python-rbd-12.2.12-74.el7cp.x86_64

Related issues 2 (0 open — 2 closed)

Copied to rbd - Backport #44838: nautilus: [python] ensure image is open before permitting operationsResolvedNathan CutlerActions
Copied to rbd - Backport #44839: octopus: [python] ensure image is open before permitting operationsResolvedNathan CutlerActions
Actions
Copy link
 #1

Updated by Mykola Golub about 4 years ago

  • Status changed from New to In Progress
  • Assignee set to Mykola Golub
Actions
Copy link
 #2

Updated by Mykola Golub about 4 years ago

  • Status changed from In Progress to Fix Under Review
  • Pull request ID set to 34112
Actions
Copy link
 #3

Updated by Jason Dillaman about 4 years ago

  • Status changed from Fix Under Review to Pending Backport
  • Backport changed from nautilus,mimic to nautilus,octopus
Actions
Copy link
 #4

Updated by Nathan Cutler about 4 years ago

  • Copied to Backport #44838: nautilus: [python] ensure image is open before permitting operations added
Actions
Copy link
 #5

Updated by Nathan Cutler about 4 years ago

  • Copied to Backport #44839: octopus: [python] ensure image is open before permitting operations added
Actions
Copy link
 #6

Updated by Nathan Cutler almost 4 years ago

  • Status changed from Pending Backport to Resolved

While running with --resolve-parent, the script "backport-create-issue" noticed that all backports of this issue are in status "Resolved" or "Rejected".

Actions
Copy link

Also available in: Atom PDF