Bug #44579
closedqa: commit 9f6c764f10f break qa code in several places
0%
Description
vstart_runner.py crashes while running tests, many of these happen because vstart_runner.LocalRemote.run doesn't take positional arguments anymore -
2020-03-12 13:39:10,098.098 INFO:__main__:====================================================================== 2020-03-12 13:39:10,099.099 INFO:__main__:ERROR: test_cd_with_args (tasks.cephfs.test_cephfs_shell.TestCD) 2020-03-12 13:39:10,099.099 INFO:__main__:---------------------------------------------------------------------- 2020-03-12 13:39:10,099.099 INFO:__main__:Traceback (most recent call last): 2020-03-12 13:39:10,099.099 INFO:__main__: File "/home/rishabh/repos/ceph/fs-shell-colors/qa/tasks/cephfs/cephfs_test_case.py", line 145, in setUp 2020-03-12 13:39:10,099.099 INFO:__main__: self.mounts[i].mount() 2020-03-12 13:39:10,099.099 INFO:__main__: File "../qa/tasks/vstart_runner.py", line 891, in mount 2020-03-12 13:39:10,099.099 INFO:__main__: self.gather_mount_info() 2020-03-12 13:39:10,100.100 INFO:__main__: File "/home/rishabh/repos/ceph/fs-shell-colors/qa/tasks/cephfs/fuse_mount.py", line 165, in gather_mount_info 2020-03-12 13:39:10,100.100 INFO:__main__: status = self.admin_socket(['status']) 2020-03-12 13:39:10,100.100 INFO:__main__: File "/home/rishabh/repos/ceph/fs-shell-colors/qa/tasks/cephfs/fuse_mount.py", line 449, in admin_socket 2020-03-12 13:39:10,100.100 INFO:__main__: ], timeout=(15*60)).strip() 2020-03-12 13:39:10,100.100 INFO:__main__:TypeError: run() takes exactly 1 argument (3 given)
There are also crashes since method sh in vstart_runner.py doesn't take argument timeout.
Updated by Rishabh Dave about 4 years ago
- Component(FS) qa-suite added
2020-03-12 13:49:45,377.377 INFO:__main__:======================================================================
2020-03-12 13:49:45,377.377 INFO:__main__:ERROR: test_cd_with_args (tasks.cephfs.test_cephfs_shell.TestCD)
2020-03-12 13:49:45,378.378 INFO:__main__:----------------------------------------------------------------------
2020-03-12 13:49:45,378.378 INFO:__main__:Traceback (most recent call last):
2020-03-12 13:49:45,378.378 INFO:__main__: File "/home/rishabh/repos/ceph/fs-shell-colors/qa/tasks/cephfs/cephfs_test_case.py", line 145, in setUp
2020-03-12 13:49:45,378.378 INFO:__main__: self.mounts[i].mount()
2020-03-12 13:49:45,378.378 INFO:__main__: File "../qa/tasks/vstart_runner.py", line 891, in mount
2020-03-12 13:49:45,378.378 INFO:__main__: self.gather_mount_info()
2020-03-12 13:49:45,379.379 INFO:__main__: File "/home/rishabh/repos/ceph/fs-shell-colors/qa/tasks/cephfs/fuse_mount.py", line 165, in gather_mount_info
2020-03-12 13:49:45,379.379 INFO:__main__: status = self.admin_socket(['status'])
2020-03-12 13:49:45,379.379 INFO:__main__: File "/home/rishabh/repos/ceph/fs-shell-colors/qa/tasks/cephfs/fuse_mount.py", line 449, in admin_socket
2020-03-12 13:49:45,379.379 INFO:__main__: ], timeout=(15*60)).strip()
2020-03-12 13:49:45,379.379 INFO:__main__:TypeError: sh() got an unexpected keyword argument 'timeout'
Updated by Rishabh Dave about 4 years ago
- Status changed from In Progress to Fix Under Review
- Pull request ID set to 33945
Updated by Patrick Donnelly almost 4 years ago
- Status changed from Fix Under Review to Resolved
- Target version set to v16.0.0
- Source set to Development
Updated by Jos Collin almost 4 years ago
- Backport set to nautilus
this needs backport to nautilus.
In nautilus:
2020-06-11 04:45:08,892.892 INFO:__main__:====================================================================== 2020-06-11 04:45:08,892.892 INFO:__main__:ERROR: test_get_authorized_ids (tasks.cephfs.test_volume_client.TestVolumeClient) 2020-06-11 04:45:08,892.892 INFO:__main__:---------------------------------------------------------------------- 2020-06-11 04:45:08,892.892 INFO:__main__:Traceback (most recent call last): 2020-06-11 04:45:08,892.892 INFO:__main__: File "/home/jcollin/ceph/qa/tasks/cephfs/test_volume_client.py", line 19, in setUp 2020-06-11 04:45:08,893.893 INFO:__main__: CephFSTestCase.setUp(self) 2020-06-11 04:45:08,893.893 INFO:__main__: File "/home/jcollin/ceph/qa/tasks/cephfs/cephfs_test_case.py", line 146, in setUp 2020-06-11 04:45:08,893.893 INFO:__main__: self.mounts[i].mount() 2020-06-11 04:45:08,893.893 INFO:__main__: File "../qa/tasks/vstart_runner.py", line 560, in mount 2020-06-11 04:45:08,893.893 INFO:__main__: self.gather_mount_info() 2020-06-11 04:45:08,893.893 INFO:__main__: File "/home/jcollin/ceph/qa/tasks/cephfs/fuse_mount.py", line 165, in gather_mount_info 2020-06-11 04:45:08,893.893 INFO:__main__: status = self.admin_socket(['status']) 2020-06-11 04:45:08,893.893 INFO:__main__: File "/home/jcollin/ceph/qa/tasks/cephfs/fuse_mount.py", line 440, in admin_socket 2020-06-11 04:45:08,893.893 INFO:__main__: timeout=(15*60)).strip() 2020-06-11 04:45:08,893.893 INFO:__main__:TypeError: sh() got an unexpected keyword argument 'stdout'
Updated by Nathan Cutler almost 4 years ago
- Status changed from Resolved to Pending Backport
Updated by Nathan Cutler almost 4 years ago
yes, 9f6c764f10f was backported to nautilus via 6e00035ab44f23f3b3ff3242ac81e69dc9f174fc
Updated by Nathan Cutler almost 4 years ago
- Backport changed from nautilus to nautilus, octopus
9f6c764f10f is in the process of being backported to octopus as well
Updated by Nathan Cutler almost 4 years ago
- Copied to Backport #46012: nautilus: qa: commit 9f6c764f10f break qa code in several places added
Updated by Nathan Cutler almost 4 years ago
- Copied to Backport #46013: octopus: qa: commit 9f6c764f10f break qa code in several places added
Updated by Nathan Cutler over 3 years ago
- Status changed from Pending Backport to Resolved
While running with --resolve-parent, the script "backport-create-issue" noticed that all backports of this issue are in status "Resolved" or "Rejected".