Project

General

Profile

Bug #44415

cephfs.pyx: passing empty string is fine but passing None is not to arg conffile in LibCephFS.__cinit__

Added by Rishabh Dave 26 days ago. Updated 19 days ago.

Status:
New
Priority:
Normal
Assignee:
Category:
-
Target version:
% Done:

0%

Source:
Development
Tags:
Backport:
octopus,nautilus
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
cephfs.pyx
Labels (FS):
Pull request ID:
Crash signature:

Description

diff --git a/src/tools/cephfs/cephfs-shell b/src/tools/cephfs/cephfs-shell
index 932b57f725..180fe577dd 100755
--- a/src/tools/cephfs/cephfs-shell
+++ b/src/tools/cephfs/cephfs-shell
@@ -1477,13 +1477,13 @@ class CephFSShell(Cmd):
 #
 #####################################################

-def setup_cephfs(config_file):
+def setup_cephfs():
     """ 
     Mounting a cephfs
     """ 
     global cephfs
     try:
-        cephfs = libcephfs.LibCephFS(conffile=config_file)
+        cephfs = libcephfs.LibCephFS()
         cephfs.mount()
     except libcephfs.ObjectNotFound as e:
         print('couldn\'t find ceph configuration not found')
@@ -1556,7 +1556,7 @@ if __name__ == '__main__':
     sys.argv.append(exe)
     sys.argv.extend([i.strip() for i in ' '.join(args.commands).split(',')])

-    setup_cephfs(config_file)
+    setup_cephfs()
     shell = CephFSShell()
     shell.exit_code = 0
     read_ceph_conf(shell, config_file)
$ ../src/tools/cephfs/cephfs-shell
unable to get monitor info from DNS SRV with service name: ceph-mon
couldn't find ceph configuration not found

History

#1 Updated by Rishabh Dave 26 days ago

According Kefu, this was probably done purposefully by original API author so that client has 3 options: first, get config from given conf file when path is passed, second, read conf files from default locations when None is passed and, third, don't read conf at all when empty string is passed.

He suggested creating new class or tag/flag to make that more clear that there are 3 options altogether.

#2 Updated by Patrick Donnelly 26 days ago

  • Assignee set to Rishabh Dave
  • Target version set to v16.0.0
  • Source set to Development
  • Backport set to octopus,nautilus

#3 Updated by Rishabh Dave 19 days ago

  • Pull request ID set to 33818

Also available in: Atom PDF