Cleanup #44410
mgr/dashboard: Refactor detail components
Status:
New
Priority:
Low
Assignee:
-
Category:
UI
Target version:
-
% Done:
0%
Tags:
Backport:
Reviewed:
Affected Versions:
Pull request ID:
Description
Some detail components assign the selection to over class attributes in the ngOnChanges method.
For example in the rgw-user-details.component.ts https://github.com/ceph/ceph/blob/master/src/pybind/mgr/dashboard/frontend/src/app/ceph/rgw/rgw-user-details/rgw-user-details.component.ts#L63 the selection gets assigned the user attribute:
this.user = this.selection;
This.user will then be used in the template (rgw-user-details.component.html) to bind the data.
In this cases we could also remove those 'wrapper' variables and use this.selection instead.
History
#1 Updated by Ernesto Puerta almost 3 years ago
- Project changed from mgr to Dashboard
#2 Updated by Ernesto Puerta almost 2 years ago
- Category set to UI