Bug #44392: mgr/orchestrator: missing SPEC and PLACEMENT field in JSON output of ServiceDescription - Orchestrator - Ceph

Actions

Copy link

Bug #44392

closed

mgr/orchestrator: missing SPEC and PLACEMENT field in JSON output of ServiceDescription

Added by Kiefer Chang about 4 years ago. Updated about 4 years ago.

Status:

Resolved

Priority:

Normal

Assignee:

Kiefer Chang

Category:

cephadm

Target version:

% Done:

Source:

Tags:

Backport:

Regression:

Severity:

3 - minor

Reviewed:

Affected Versions:

ceph-qa-suite:

Pull request ID:

33779

Crash signature (v1):

Crash signature (v2):

Description

A new column `SPEC` was added in PR https://github.com/ceph/ceph/pull/33553.
And PLACEMENT field was added in PR https://github.com/ceph/ceph/pull/33667.

The JSON output of `orch ls` doesn't include these fields:


╭─root@ceph-1 /ceph/build ‹master-0305*› 
╰─# bin/ceph orch ls                                                                                                                                                   22 ↵
*** DEVELOPER MODE: setting PATH, PYTHONPATH and LD_LIBRARY_PATH ***
2020-03-05T06:44:25.552+0000 7f1cf2553700 -1 WARNING: all dangerous and experimental features are enabled.
2020-03-05T06:44:25.576+0000 7f1cf2553700 -1 WARNING: all dangerous and experimental features are enabled.
NAME  RUNNING  REFRESHED  IMAGE NAME                                            IMAGE ID      SPEC     PLACEMENT   
mgr       1/1  2m ago     docker.io/ceph/daemon-base:latest-master-devel        42d3bee0030b  present  hosts=mgr0  
osd       4/4  2m ago     172.17.0.1:5001/ceph/daemon-base:latest-master-devel  42d3bee0030b  -        - 

╭─root@ceph-1 /ceph/build ‹master-0305*› 
╰─# bin/ceph orch ls --format=json | jq
*** DEVELOPER MODE: setting PATH, PYTHONPATH and LD_LIBRARY_PATH ***
2020-03-05T06:59:56.399+0000 7f3cb72cd700 -1 WARNING: all dangerous and experimental features are enabled.
2020-03-05T06:59:56.423+0000 7f3cb72cd700 -1 WARNING: all dangerous and experimental features are enabled.
[
  {
    "container_image_id": "42d3bee0030b20d67f9a3eb510ff800f7e0ae614234df165c93b2161e1c53c71",
    "container_image_name": "docker.io/ceph/daemon-base:latest-master-devel",
    "service_name": "mgr",
    "size": 1,
    "running": 1,
    "last_refresh": "2020-03-05T06:52:20.217253" 
  },
  {
    "container_image_id": "42d3bee0030b20d67f9a3eb510ff800f7e0ae614234df165c93b2161e1c53c71",
    "container_image_name": "172.17.0.1:5001/ceph/daemon-base:latest-master-devel",
    "service_name": "osd",
    "size": 4,
    "running": 4,
    "last_refresh": "2020-03-05T06:52:17.970096" 
  }
]

We need to include it for consistency.

Actions

Copy link

Updated by Kiefer Chang about 4 years ago

Status changed from In Progress to Fix Under Review
Pull request ID set to 33685

Actions

Copy link

Updated by Kiefer Chang about 4 years ago

Subject changed from mgr/orchestrator: missing spec_presence field in JSON output of ServiceDescription to mgr/orchestrator: missing SPEC and PLACEMENT field in JSON output of ServiceDescription
Description updated (diff)
Status changed from Fix Under Review to In Progress