Project

General

Profile

Actions

Cleanup #44379

closed

orchestrator: {to,from}_json inconsistent

Added by Sage Weil about 4 years ago. Updated about 4 years ago.

Status:
Won't Fix
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
% Done:

0%

Tags:
Backport:
Reviewed:
Affected Versions:
Pull request ID:

Description

sometimes to_json returns a dict (that can be fed to json.dumps), sometimes it returns the JSON string. We should be consistent

Actions #1

Updated by Sebastian Wagner about 4 years ago

to,from}_json should not accept strings and instead always accept/return dicts or lists.

Actions #2

Updated by Sebastian Wagner about 4 years ago

  • Status changed from New to Won't Fix
  • Pull request ID set to 33956

not worth the effort right now.

Actions

Also available in: Atom PDF