Project

General

Profile

Actions

Bug #44210

closed

Devicehealth scrape fails when smartctl return code is non-zero

Added by Benoît Knecht about 4 years ago. Updated about 4 years ago.

Status:
Resolved
Priority:
Urgent
Assignee:
-
Category:
devicehealth module
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
nautilus
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

Ceph-mgr doesn't handle correctly the case where smartctl returns with a non-zero exit code, which leads to (misguiding) "smartctl returned invalid JSON" errors in scraping results.


Related issues 1 (0 open1 closed)

Copied to mgr - Backport #44218: nautilus: Devicehealth scrape fails when smartctl return code is non-zeroResolvedKonstantin ShalyginActions
Actions #1

Updated by Benoît Knecht about 4 years ago

(I can't seem to be able to set the status to "Pending Backport," but the purpose of this issue is only to act as the master tracker issue for the Nautilus backport tracker issue.)

Actions #2

Updated by Sage Weil about 4 years ago

  • Status changed from New to Pending Backport
  • Assignee deleted (Sage Weil)
  • Priority changed from Normal to Urgent
Actions #3

Updated by Benoît Knecht about 4 years ago

I tried running `src/script/backport-create-issue 44210`, but I do not have sufficient permissions to do so:

```
WARNING:root:Missing issues will be created in Backport tracker of the relevant Redmine project
INFO:root:Redmine key was read from '~/.redmine_key'; using it
INFO:root:Processing issue list >44210<
INFO:root:Processing 1 issues with status Pending Backport
Traceback (most recent call last):
File "src/script/backport-create-issue", line 343, in <module>
iterate_over_backports(redmine, issues, dry_run=args.dry_run)
File "src/script/backport-create-issue", line 298, in iterate_over_backports
update_relations(r, issue, dry_run)
File "src/script/backport-create-issue", line 182, in update_relations
for relation in relations:
File "/usr/lib/lib/python3.7/site-packages/redminelib/resultsets.py", line 278, in iter
return (self.manager.to_resource(resource) for resource in super(ResourceSet, self).__iter__())
File "/usr/lib/lib/python3.7/site-packages/redminelib/resultsets.py", line 111, in iter
'get', self.manager.url, self.manager.container, **self.manager.params)
File "/usr/lib/lib/python3.7/site-packages/redminelib/engines/base.py", line 89, in bulk_request
response = self.request(method, url, params=dict(params, limit=limit or self.chunk, offset=offset))
File "/usr/lib/lib/python3.7/site-packages/redminelib/engines/base.py", line 76, in request
return self.process_response(self.session.request(method, url, **kwargs))
File "/usr/lib/lib/python3.7/site-packages/redminelib/engines/base.py", line 155, in process_response
raise exceptions.ForbiddenError
redminelib.exceptions.ForbiddenError: Requested resource is forbidden
```

Actions #4

Updated by Konstantin Shalygin about 4 years ago

  • Copied to Backport #44218: nautilus: Devicehealth scrape fails when smartctl return code is non-zero added
Actions #5

Updated by Nathan Cutler about 4 years ago

  • Status changed from Pending Backport to Resolved

While running with --resolve-parent, the script "backport-create-issue" noticed that all backports of this issue are in status "Resolved" or "Rejected".

Actions

Also available in: Atom PDF