Bug #44117: vstart_runner.py: align LocalRemote.run with teuthology's run - CephFS - Ceph

Actions

Copy link

Bug #44117

closed

vstart_runner.py: align LocalRemote.run with teuthology's run

Added by Rishabh Dave about 4 years ago. Updated about 4 years ago.

Status:

Resolved

Priority:

Normal

Assignee:

Rishabh Dave

Category:

Target version:

Ceph - v15.0.0

% Done:

Source:

Development

Tags:

Backport:

Regression:

Severity:

3 - minor

Reviewed:

Affected Versions:

ceph-qa-suite:

Component(FS):

qa-suite

Labels (FS):

Pull request ID:

33263

Crash signature (v1):

Crash signature (v2):

Description

teuthology's run uses keyword argument but that's not the case for vstart_runner.py. This gets the test passing with vstart_runner.py but it some cases the testing with teuthology goes unsuccessful. Therefore it's better to keep the interfaces aligned so that the test-writer gets the warning without a trip of teuthology testing.

Calls like client_remote.run([<cmdargs>], <more-args>) falls into this categoery. These calls ideally should be client_remote.run(args=[<cmdargs>], <more-KWargs>).

Actions

Copy link

Updated by Rishabh Dave about 4 years ago

Subject changed from vstart_runner.py: align LocalRemoteProcess.run with teuthology's run to vstart_runner.py: align LocalRemote.run with teuthology's run

Actions

Copy link

Updated by Rishabh Dave about 4 years ago

Pull request ID set to 33263

Actions

Copy link

Updated by Rishabh Dave about 4 years ago

I was able to reproduce the bug; see /ceph/teuthology-archive/rishabh-2020-02-20_07:10:45-fs-wip-rishabh-dummy-test-distro-basic-smithi/4783938/teuthology.log or http://pulpito.ceph.com/rishabh-2020-02-20_07:10:45-fs-wip-rishabh-dummy-test-distro-basic-smithi/.

Here's the stacktrace -

2020-02-20T07:52:41.115 INFO:tasks.cephfs_test_runner:======================================================================
2020-02-20T07:52:41.115 INFO:tasks.cephfs_test_runner:ERROR: test_dummy (tasks.cephfs.test_cephfs_shell.TestDummy)
2020-02-20T07:52:41.116 INFO:tasks.cephfs_test_runner:----------------------------------------------------------------------
2020-02-20T07:52:41.116 INFO:tasks.cephfs_test_runner:Traceback (most recent call last):
2020-02-20T07:52:41.116 INFO:tasks.cephfs_test_runner:  File "/home/teuthworker/src/git.ceph.com_ceph-c_wip-rishabh-dummy-test/qa/tasks/cephfs/test_cephfs_shell.py", line 996, in test_dummy
2020-02-20T07:52:41.116 INFO:tasks.cephfs_test_runner:    self.mount_a.client_remote.run(['ls', '/etc/'], check_status=True)
2020-02-20T07:52:41.116 INFO:tasks.cephfs_test_runner:TypeError: run() takes exactly 1 argument (3 given)
2020-02-20T07:52:41.116 INFO:tasks.cephfs_test_runner:
2020-02-20T07:52:41.116 INFO:tasks.cephfs_test_runner:----------------------------------------------------------------------
2020-02-20T07:52:41.116 INFO:tasks.cephfs_test_runner:Ran 19 tests in 979.765s

Actions

Copy link