Project

General

Profile

Bug #44117

vstart_runner.py: align LocalRemote.run with teuthology's run

Added by Rishabh Dave about 2 months ago. Updated about 1 month ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
% Done:

0%

Source:
Development
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
qa-suite
Labels (FS):
Pull request ID:
Crash signature:

Description

teuthology's run uses keyword argument but that's not the case for vstart_runner.py. This gets the test passing with vstart_runner.py but it some cases the testing with teuthology goes unsuccessful. Therefore it's better to keep the interfaces aligned so that the test-writer gets the warning without a trip of teuthology testing.

Calls like client_remote.run([<cmdargs>], <more-args>) falls into this categoery. These calls ideally should be client_remote.run(args=[<cmdargs>], <more-KWargs>).

History

#1 Updated by Rishabh Dave about 2 months ago

  • Subject changed from vstart_runner.py: align LocalRemoteProcess.run with teuthology's run to vstart_runner.py: align LocalRemote.run with teuthology's run

#2 Updated by Rishabh Dave about 2 months ago

  • Pull request ID set to 33263

#3 Updated by Rishabh Dave about 1 month ago

I was able to reproduce the bug; see /ceph/teuthology-archive/rishabh-2020-02-20_07:10:45-fs-wip-rishabh-dummy-test-distro-basic-smithi/4783938/teuthology.log or http://pulpito.ceph.com/rishabh-2020-02-20_07:10:45-fs-wip-rishabh-dummy-test-distro-basic-smithi/.

Here's the stacktrace -

2020-02-20T07:52:41.115 INFO:tasks.cephfs_test_runner:======================================================================
2020-02-20T07:52:41.115 INFO:tasks.cephfs_test_runner:ERROR: test_dummy (tasks.cephfs.test_cephfs_shell.TestDummy)
2020-02-20T07:52:41.116 INFO:tasks.cephfs_test_runner:----------------------------------------------------------------------
2020-02-20T07:52:41.116 INFO:tasks.cephfs_test_runner:Traceback (most recent call last):
2020-02-20T07:52:41.116 INFO:tasks.cephfs_test_runner:  File "/home/teuthworker/src/git.ceph.com_ceph-c_wip-rishabh-dummy-test/qa/tasks/cephfs/test_cephfs_shell.py", line 996, in test_dummy
2020-02-20T07:52:41.116 INFO:tasks.cephfs_test_runner:    self.mount_a.client_remote.run(['ls', '/etc/'], check_status=True)
2020-02-20T07:52:41.116 INFO:tasks.cephfs_test_runner:TypeError: run() takes exactly 1 argument (3 given)
2020-02-20T07:52:41.116 INFO:tasks.cephfs_test_runner:
2020-02-20T07:52:41.116 INFO:tasks.cephfs_test_runner:----------------------------------------------------------------------
2020-02-20T07:52:41.116 INFO:tasks.cephfs_test_runner:Ran 19 tests in 979.765s

#4 Updated by Patrick Donnelly about 1 month ago

  • Status changed from Fix Under Review to Resolved
  • Target version set to v15.0.0
  • Source set to Development

Also available in: Atom PDF