Cleanup #4403
closedlibceph: refactor messenger for multiple data sources
0%
Description
This really was work needed to make it easier to have
the messenger deal with multiple sources of data, and
to treat them generically. There are a few more patches
that can be added to this after a little more testing,
but I plan to post the following for review today. I
thought I should open up a distinct issue for this,
because it accounts for a couple of days work that
is otherwise associated with the multiple data items
task (http://tracker.ceph.com/issues/4125).
[PATCH 0/6] libceph: refactor messenger for multiple data sources
[PATCH 1/6] libceph: use local variables for message positions
[PATCH 2/6] libceph: consolidate message prep code
[PATCH 3/6] libceph: small write_partial_msg_pages() refactor
[PATCH 4/6] libceph: encapsulate reading message data
[PATCH 5/6] libceph: define and use ceph_tcp_recvpage()
[PATCH 6/6] libceph: define and use ceph_crc32c_page()
Updated by Alex Elder about 11 years ago
- Status changed from In Progress to 4
I have posted these for review. But I updated them
and I need to re-test them (I normally do that before
I post them for review...)
Updated by Alex Elder about 11 years ago
Well, as I should have expected, the testing was important.
I found two bugs in one of these patches, and reposted an
update for it once for each. I think all is well now.
This:
[PATCH 4/6] libceph: encapsulate reading message data
was deprecated by this:
[PATCH 4/6, v2] libceph: encapsulate reading message data
And both of those are replaced by this final version:
[PATCH 4/6, v3] libceph: encapsulate reading message data
Updated by Alex Elder about 11 years ago
- Status changed from 4 to Resolved
These have been reviewed and are now committed to the testing branch.
5478489 libceph: use local variables for message positions
7c1775e libceph: consolidate message prep code
86dc530 libceph: small write_partial_msg_pages() refactor
473a03c libceph: encapsulate reading message data
fb2177d libceph: define and use ceph_tcp_recvpage()
3f76347 libceph: define and use ceph_crc32c_page()