Project

General

Profile

Bug #44027

cephadm: usability: python backtrace on usage error

Added by Yehuda Sadeh 10 months ago. Updated 10 months ago.

Status:
Resolved
Priority:
Normal
Category:
-
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature:

Description

Failure to provide a required param ends with the following unnecessary backtrace:

[ceph: root@mira118 /]# ceph orchestrator mon update 2 mira115.front.sepia.ceph.com
Error EINVAL: Traceback (most recent call last):
  File "/usr/share/ceph/mgr/mgr_module.py", line 1069, in _handle_command
    return CLICommand.COMMANDS[cmd['prefix']].call(self, cmd, inbuf)
  File "/usr/share/ceph/mgr/mgr_module.py", line 309, in call
    return self.func(mgr, **kwargs)
  File "/usr/share/ceph/mgr/orchestrator.py", line 140, in wrapper
    return func(*args, **kwargs)
  File "/usr/share/ceph/mgr/orchestrator_cli/module.py", line 641, in _update_mons
    completion = self.update_mons(spec)
  File "/usr/share/ceph/mgr/orchestrator.py", line 1445, in inner
    completion = self._oremote(method_name, args, kwargs)
  File "/usr/share/ceph/mgr/orchestrator.py", line 1515, in _oremote
    return mgr.remote(o, meth, *args, **kwargs)
  File "/usr/share/ceph/mgr/mgr_module.py", line 1429, in remote
    args, kwargs)
RuntimeError: Remote method threw exception: Traceback (most recent call last):
  File "/usr/share/ceph/mgr/cephadm/module.py", line 1697, in update_mons
    return self._update_mons(spec)
  File "/usr/share/ceph/mgr/cephadm/module.py", line 1719, in _update_mons
    raise RuntimeError("Host '{}' is missing a network spec".format(host))
RuntimeError: Host 'mira115.front.sepia.ceph.com' is missing a network spec

History

#1 Updated by Sebastian Wagner 10 months ago

  • Status changed from New to Fix Under Review
  • Assignee set to Sebastian Wagner
  • Pull request ID set to 33333

#2 Updated by Sebastian Wagner 10 months ago

  • Status changed from Fix Under Review to Resolved

Also available in: Atom PDF