Project

General

Profile

Actions

Cleanup #4400

closed

libceph: various cleanups

Added by Alex Elder about 11 years ago. Updated about 11 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Target version:
-
% Done:

0%

Tags:
Backport:
Reviewed:
Affected Versions:
Pull request ID:

Description

I was going to do this before but now I've posted the patches
for review, so I'm doing it after the fact. They're now
in need of review.

As I've been working on getting the ceph kernel messenger to
support multiple chunks of data in a single message I have
run across small changes that either are tiny bug fixes,
code cleanups, or minor refactorizations, none of which
seems worth the "paperwork" of a separate issue.

As I find these I fix them in a separate patch and move
it to the front of my patch list. And like now, I will
periodically take a group of them and put them out for
a review together.

So that's what this is about. Below is the description
I sent out ahead of the patches.

This series contains a bunch of small cleanups. All of
them I've created while working on other things, and most
of them were done in order to allow upcoming work to be
easier, or easier to understand. I've moved them all to
the front of my stack of patches and now I'm posting them
as a set for review. They apply on top of the ceph-client
"testing" branch as of a couple of days ago:
2f60d302 libceph: fix decoding of pgids

[PATCH 0/8] libceph: miscellaneous cleanups
[PATCH 1/8] libceph: define CEPH_MSG_MAX_MIDDLE_LEN
[PATCH 2/8] libceph: minor byte order problems in
[PATCH 3/8] libceph: change type of ceph_tcp_sendpage() "more"
[PATCH 4/8] libceph: kill args in read_partial_message_bio()
[PATCH 5/8] libceph: define and use in_msg_pos_next()
[PATCH 6/8] libceph: advance pagelist with list_rotate_left()
[PATCH 7/8] libceph: simplify new message initialization
[PATCH 8/8] libceph: record byte count not page count

Actions #1

Updated by Alex Elder about 11 years ago

  • Status changed from 4 to Resolved

Josh has reviewed these and they have now been committed
to the testing branch:
1e82218 libceph: define CEPH_MSG_MAX_MIDDLE_LEN
479066e libceph: minor byte order problems in read_partial_message()
c4e8b22 libceph: change type of ceph_tcp_sendpage() "more"
3bfaa45 libceph: kill args in read_partial_message_bio()
7ac3ec3 libceph: define and use in_msg_pos_next()
714b861 libceph: advance pagelist with list_rotate_left()
f1e83e8 libceph: simplify new message initialization
c9582368 libceph: record byte count not page count

Actions

Also available in: Atom PDF