Project

General

Profile

Actions
Copy link

Bug #43746

closed

mgr default value handling is broken

Added by Sage Weil over 4 years ago. Updated about 4 years ago.

Status:
Resolved
Priority:
Urgent
Assignee:
Sage Weil
Category:
-
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
nautilus, octopus
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
32755
Crash signature (v1):
Crash signature (v2):

Description

most mgr modules have a config_notify() that does

             setattr(self,
                     opt['name'],  # type: ignore
                     self.get_module_option(opt['name']) or opt['default'])  # type: ignore

which is applied after the get_module_option in mgr_module.py already sorts out the default values. this breaks any values of 0 or false or none or ''.

Related issues 2 (0 open — 2 closed)

Copied to mgr - Backport #43820: nautilus: mgr default value handling is brokenResolvedNathan CutlerActions
Copied to mgr - Backport #44754: octopus: mgr default value handling is brokenResolvedNathan CutlerActions
Actions
Copy link
 #1

Updated by Sage Weil over 4 years ago

  • Status changed from In Progress to Fix Under Review
  • Pull request ID set to 32755
Actions
Copy link
 #2

Updated by Sage Weil about 4 years ago

  • Status changed from Fix Under Review to Pending Backport
Actions
Copy link
 #3

Updated by Nathan Cutler about 4 years ago

  • Copied to Backport #43820: nautilus: mgr default value handling is broken added
Actions
Copy link
 #4

Updated by Kefu Chai about 4 years ago

  • Backport changed from nautilus to nautilus, octopus
Actions
Copy link
 #5

Updated by Nathan Cutler about 4 years ago

backporting note: https://github.com/ceph/ceph/pull/34117 (follow-on fix)

Actions
Copy link
 #6

Updated by Nathan Cutler about 4 years ago

  • Copied to Backport #44754: octopus: mgr default value handling is broken added
Actions
Copy link
 #7

Updated by Nathan Cutler about 4 years ago

  • Status changed from Pending Backport to Resolved

While running with --resolve-parent, the script "backport-create-issue" noticed that all backports of this issue are in status "Resolved" or "Rejected".

Actions
Copy link

Also available in: Atom PDF