Bug #43715: mgr/dashboard: feature toggles is broken - Dashboard - Ceph

Actions

Copy link

Bug #43715

closed

mgr/dashboard: feature toggles is broken

Added by Ernesto Puerta about 4 years ago. Updated about 3 years ago.

Status:

Resolved

Priority:

Normal

Assignee:

Ernesto Puerta

Category:

General

Target version:

Ceph - v15.0.0

% Done:

Source:

Tags:

Backport:

Regression:

Yes

Severity:

3 - minor

Reviewed:

Affected Versions:

ceph-qa-suite:

Pull request ID:

32419

Crash signature (v1):

Crash signature (v2):

Description

3 changes have broken the feature-toggles:
- Bootstrap update PR removed part of feature toggles in Navigation component, and also moved main drop-down menu to a separate ng-template, causing the context in the ng-template to be missing.
- Moving service injection from Service to 'root' (this might be the cause for the issue below, but changed the way the singleton-ness of the FeatureTogglesService worked)
- Migrate e2e tests to async await, specifically Angular is creating multiple instances of the same service (this definitely broke the singleton+multicast behaviour of the FeatureTogglesService).

The reason why this could go undetected is because feature-toggles lacked tests in the navigation component (unlike health page or routing module, where feature toggling is tested).