Project

General

Profile

Bug #43645

mgr/volumes: subvolumes with snapshots can be deleted

Added by Venky Shankar 3 months ago. Updated about 2 months ago.

Status:
Resolved
Priority:
High
Assignee:
Category:
Correctness/Safety
Target version:
% Done:

0%

Source:
Community (dev)
Tags:
Backport:
nautilus
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
mgr/volumes
Labels (FS):
Pull request ID:
Crash signature:

Description

$ ceph fs subvolume create cephfs zig
$ ceph fs subvolume snapshot create cephfs zig zig-snap0
$ ceph fs subvolume rm cephfs zig

Since deletion is asynchronous (rename+background purge), the rename succeeds. But the purge threads are unable to purge the entry in trash

2020-01-17T04:26:51.650-0500 7f042a808700  0 [volumes] [DEBUG] [volumes.fs.purge_queue] registering purge job: cephfs.b'48cc3cb5-78e9-4c75-be22-82e8c782fe91'
2020-01-17T04:26:51.650-0500 7f042a808700  0 [volumes] [DEBUG] [volumes.fs.purge_queue] purging trash entry 'b'48cc3cb5-78e9-4c75-be22-82e8c782fe91'' for volume 'cephfs'
2020-01-17T04:26:51.650-0500 7f042a808700  0 [volumes] [DEBUG] [volumes.fs.operations.volume] self.fs_id=50, fs_id=50
2020-01-17T04:26:51.651-0500 7f042a808700  0 [volumes] [DEBUG] [volumes.fs.operations.trash] rmtree b'/volumes/_deleting/48cc3cb5-78e9-4c75-be22-82e8c782fe91'
2020-01-17T04:26:51.654-0500 7f042a808700  0 [volumes] [DEBUG] [volumes.fs.operations.trash] rmtree b'/volumes/_deleting/48cc3cb5-78e9-4c75-be22-82e8c782fe91/307c9153-e36b-44b6-b264-a82287535b0f'
2020-01-17T04:26:51.659-0500 7f042a808700  0 [volumes] [WARNING] [volumes.fs.purge_queue] failed to purge cephfs.b'48cc3cb5-78e9-4c75-be22-82e8c782fe91' (-39)
2020-01-17T04:26:51.659-0500 7f042a808700  0 [volumes] [DEBUG] [volumes.fs.purge_queue] unregistering purge job: cephfs.b'48cc3cb5-78e9-4c75-be22-82e8c782fe91'

For the fix, fail the delete (rm) operation if a subvolume has snapshots.


Related issues

Copied to fs - Backport #43724: nautilus: mgr/volumes: subvolumes with snapshots can be deleted Resolved

History

#1 Updated by Venky Shankar 3 months ago

  • Status changed from In Progress to Fix Under Review
  • Pull request ID set to 32696

#2 Updated by Patrick Donnelly 3 months ago

  • Status changed from Fix Under Review to Pending Backport
  • Target version set to v15.0.0

#3 Updated by Nathan Cutler 3 months ago

  • Copied to Backport #43724: nautilus: mgr/volumes: subvolumes with snapshots can be deleted added

#4 Updated by Ramana Raja about 2 months ago

  • Status changed from Pending Backport to Resolved

Also available in: Atom PDF