Project

General

Profile

Actions
Copy link

Bug #43610

open

mgr/dashboard: perform validation on GRAFANA_API_URL

Added by Ernesto Puerta over 4 years ago. Updated over 1 year ago.

Status:
Fix Under Review
Priority:
Normal
Assignee:
Francesco Torchia
Category:
Monitoring
Target version:
-
% Done:

100%

Source:
Q/A
Tags:
low-hanging-fruit
Backport:
nautilus
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
47755
Crash signature (v1):
Crash signature (v2):

Description

Currently GRAFANA_API_URL expects "http[s]://<FQDN>:<port>" syntax, but allows also "<FQDN>:<port>".

However that latter expression results in the concatenation of the Dashboard address + Grafana address (e.g.: Grafana Iframe source points to "http://<dash_hostname>:<dash_port>/<grafana_hostname>:<grafana_port>"/d/...").

Unless is for an intentional use-case, the CLI command "ceph dashboard set-grafana-api-url" should perform some check and indicate any errors if this format is entered.

Actions
Copy link
 #1

Updated by Ricardo Marques over 4 years ago

  • Tags set to low-hanging-fruit
Actions
Copy link
 #2

Updated by Ernesto Puerta about 3 years ago

  • Translation missing: en.field_tag_list set to low-hanging-fruit
Actions
Copy link
 #3

Updated by Ernesto Puerta about 3 years ago

  • Project changed from mgr to Dashboard
  • Category changed from 148 to Monitoring
Actions
Copy link
 #4

Updated by Volker Theile over 1 year ago

  • Assignee set to Francesco Torchia
Actions
Copy link
 #5

Updated by Francesco Torchia over 1 year ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 50
Actions
Copy link
 #6

Updated by Francesco Torchia over 1 year ago

  • Status changed from In Progress to Fix Under Review
  • % Done changed from 50 to 100
  • Pull request ID set to 47755
Actions
Copy link

Also available in: Atom PDF