Project

General

Profile

Actions

Bug #43589

closed

Potential live-lock in disable/enable feature request

Added by Jason Dillaman over 4 years ago. Updated about 4 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
luminous,mimic,nautilus
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

http://pulpito.ceph.com/trociny-2020-01-10_18:15:56-rbd-wip-mgolub-testing-distro-basic-smithi/4653631

For example, if a disable journal feature request is received by a lock owner, the DisableFeaturesRequest state machine will start "ImageState::prepare_lock" which will prevent future image state updates (like image refreshes) until the prepare lock step is completed. However, if a header update notification is received while in this state, the DisableFeaturesRequest state machine will attempt to disable mirroring which involves a refresh image step. This will live-lock and the state machines will never advance. It seems the simple solution would be to extract the refresh step from the librbd::mirror::GetInfoRequest state machine and instead move the refresh to the API callers.


Related issues 3 (0 open3 closed)

Copied to rbd - Backport #43829: mimic: Potential live-lock in disable/enable feature requestResolvedShyukri ShyukrievActions
Copied to rbd - Backport #43830: nautilus: Potential live-lock in disable/enable feature requestResolvedNathan CutlerActions
Copied to rbd - Backport #43831: luminous: Potential live-lock in disable/enable feature requestResolvedNathan CutlerActions
Actions #1

Updated by Mykola Golub over 4 years ago

  • Status changed from New to Fix Under Review
  • Pull request ID set to 32734
Actions #2

Updated by Jason Dillaman about 4 years ago

  • Status changed from Fix Under Review to Pending Backport
Actions #3

Updated by Nathan Cutler about 4 years ago

  • Copied to Backport #43829: mimic: Potential live-lock in disable/enable feature request added
Actions #4

Updated by Nathan Cutler about 4 years ago

  • Copied to Backport #43830: nautilus: Potential live-lock in disable/enable feature request added
Actions #5

Updated by Nathan Cutler about 4 years ago

  • Copied to Backport #43831: luminous: Potential live-lock in disable/enable feature request added
Actions #6

Updated by Nathan Cutler about 4 years ago

  • Status changed from Pending Backport to Resolved

While running with --resolve-parent, the script "backport-create-issue" noticed that all backports of this issue are in status "Resolved" or "Rejected".

Actions

Also available in: Atom PDF