Project

General

Profile

Bug #43527

mgr/dashboard: read-only modals

Added by Ernesto Puerta over 3 years ago. Updated over 2 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Nizamudeen A
Category:
Component - Users & Roles
Target version:
Ceph - v16.0.0
% Done:

0%

Source:
Q/A
Tags:
Backport:
octopus, nautilus
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
Ceph - v14.0.0, Ceph - v14.2.0, Ceph - v14.2.1
ceph-qa-suite:
Pull request ID:
34545
Crash signature (v1):
Crash signature (v2):

Description

Currently, the read-only user can click on some modals (like Cluster -> OSD -> Cluster-wide flags, Recovery or PG Scrub settings).

While the values in those modals can't be saved (no "Apply/Save/Edit" button is displayed, only "Cancel"), it's a bit misleading to allow read-only users modify those values, while those changes can't be saved.

Hence, the read-only user should be shown with 'read-only' modals, where all form inputs are read-only.

Related issues

Duplicated by Dashboard - Feature #39251: mgr/dashboard: Deactivate config option input fields for read-only users Duplicate
Copied to Dashboard - Backport #47538: nautilus: mgr/dashboard: read-only modals Resolved
Copied to Dashboard - Backport #47539: octopus: mgr/dashboard: read-only modals Resolved

History

#1 Updated by Tatjana Dehler over 3 years ago

I'm wondering if this can be implemented as part of the 'ModalComponent' (https://github.com/ceph/ceph/blob/master/src/pybind/mgr/dashboard/frontend/src/app/shared/components/modal/modal.component.ts) so that we don't have to set it for every modal dialog explicitly.

#2 Updated by Alfonso Martínez over 3 years ago

  • Status changed from New to Fix Under Review
  • Assignee set to Nizamudeen A
  • Pull request ID set to 43527

#3 Updated by Alfonso Martínez over 3 years ago

  • Pull request ID changed from 43527 to 34545

#4 Updated by Tatjana Dehler over 3 years ago

  • Affected Versions v14.0.0, v14.2.0, v14.2.1 added

#5 Updated by Lenz Grimmer over 3 years ago

  • Duplicated by Feature #39251: mgr/dashboard: Deactivate config option input fields for read-only users added

#6 Updated by Lenz Grimmer about 3 years ago

  • Status changed from Fix Under Review to Pending Backport
  • Target version changed from v15.0.0 to v16.0.0
  • Backport changed from nautilus to octopus, nautilus

#7 Updated by Nizamudeen A about 3 years ago

  • Copied to Backport #47538: nautilus: mgr/dashboard: read-only modals added

#8 Updated by Nizamudeen A about 3 years ago

  • Related to Backport #47539: octopus: mgr/dashboard: read-only modals added

#10 Updated by Nathan Cutler about 3 years ago

  • Related to deleted (Backport #47539: octopus: mgr/dashboard: read-only modals)

#11 Updated by Nathan Cutler about 3 years ago

  • Copied to Backport #47539: octopus: mgr/dashboard: read-only modals added

#12 Updated by Nizamudeen A almost 3 years ago

  • Status changed from Pending Backport to Resolved

#13 Updated by Ernesto Puerta over 2 years ago

  • Project changed from mgr to Dashboard
  • Category changed from 150 to Component - Users & Roles

Also available in: Atom PDF