Project

General

Profile

Actions

Bug #43406

open

unittest_confutil crashes on NON-ASCII chars

Added by Willem Jan Withagen over 4 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
common
Target version:
-
% Done:

0%

Source:
Community (dev)
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

Testing with Boost 1.72 unittest_confutil crashes with:

[ RUN      ] ConfUtils.ReadFiles2
Assertion failed: (strict_ischar(ch)), function isblank, file /usr/local/include/boost/spirit/home/support/char_encoding/standard.hpp, line 129.
Abort

Which is due to the fact that in Boost 1.72 most of the character testing has been garded with an assert to make sure char holds an ascii char.
Like:

        static bool
        isblank BOOST_PREVENT_MACRO_SUBSTITUTION (int ch)
        {
            BOOST_ASSERT(strict_ischar(ch));
            return (ch == ' ' || ch == '\t');
        }

And ReadFile2 explicitly tests for strings with char value > 0x7f.
So that is certainly going to crash.

Now I can imagine that we would like to be able to have users use different encodings for things like logfiles.
But for now that is not going to work with the boost:spirit parser

No data to display

Actions

Also available in: Atom PDF