Project

General

Profile

Actions

Bug #4322

closed

libceph: define mds_alloc_msg() method

Added by Alex Elder about 11 years ago. Updated about 11 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
-
% Done:

0%

Source:
Development
Tags:
Backport:
Regression:
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

The only user of the ceph messenger that doesn't define an alloc_msg
method is the mds client. Define one, such that it works just like
it did before, and simplify ceph_con_in_msg_alloc() by assuming the
alloc_msg method is always present.

Signed-off-by: Alex Elder <>

Also, doing this (and some subsequent work) made this obvious
also:

libceph: no need for alignment for mds message

Currently, incoming mds messages never use page data, which means
there is no need to set the page_alignment field in the message.

Signed-off-by: Alex Elder <>

Actions #1

Updated by Ian Colle about 11 years ago

  • Assignee set to Alex Elder
Actions #2

Updated by Alex Elder about 11 years ago

  • Status changed from In Progress to Fix Under Review

These patches have been posted for review:

[PATCH 0/3] libceph: simplify incoming message allocation
[PATCH 1/3] libceph: drop mutex while allocating a message
[PATCH 2/3] libceph: define mds_alloc_msg() method
[PATCH 3/3] libceph: no need for alignment for mds message

Actions #3

Updated by Alex Elder about 11 years ago

  • Status changed from Fix Under Review to Resolved

These have been committed to the ceph-client testing branch:

fa14129 libceph: define mds_alloc_msg() method
95f246b libceph: drop mutex while allocating a message
6e3354a libceph: rename ceph_calc_object_layout()

Actions

Also available in: Atom PDF