Project

General

Profile

Bug #43027

mgr/dashboard: Improve iSCSI IQN validation message when spaces are used

Added by Ricardo Marques 4 months ago. Updated 2 months ago.

Status:
Resolved
Priority:
Normal
Category:
dashboard/iscsi
Target version:
% Done:

0%

Source:
Tags:
low-hanging-fruit
Backport:
nautilus
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature:

Description

If I try to create an iSCSI target with a space in the IQN, I see the following message:

It's hard no notice that I'm using a space, especially if space appears in the beginning or in the end.

To fix this, we should have a dedicated error message for this scenario.

iqn_spaces_before.png View (12 KB) Ricardo Marques, 11/26/2019 11:42 AM


Related issues

Copied to mgr - Backport #43083: nautilus: mgr/dashboard: Improve iSCSI IQN validation message when spaces are used Resolved

History

#1 Updated by Lenz Grimmer 4 months ago

That's indeed a "gotcha" which can likely happen when cut & pasting IQNs from another application or email message. Would it make sense to automatically trim white space here instead?

#2 Updated by Ricardo Marques 4 months ago

  • Status changed from New to In Progress

#3 Updated by Ricardo Marques 4 months ago

Lenz Grimmer wrote:

That's indeed a "gotcha" which can likely happen when cut & pasting IQNs from another application or email message. Would it make sense to automatically trim white space here instead?

Agree. I'll do that.

#4 Updated by Ricardo Marques 4 months ago

  • Status changed from In Progress to Fix Under Review
  • Pull request ID set to 31888

#5 Updated by Lenz Grimmer 4 months ago

  • Status changed from Fix Under Review to Pending Backport

#6 Updated by Ricardo Marques 4 months ago

  • Copied to Backport #43083: nautilus: mgr/dashboard: Improve iSCSI IQN validation message when spaces are used added

#7 Updated by Nathan Cutler 2 months ago

  • Status changed from Pending Backport to Resolved

While running with --resolve-parent, the script "backport-create-issue" noticed that all backports of this issue are in status "Resolved" or "Rejected".

Also available in: Atom PDF