Project

General

Profile

Bug #42958

mgr/PyModule.cc: set_config with an empty value doesn't remove the config option

Added by Tim Serong over 1 year ago. Updated about 2 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
ceph-mgr
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
nautilus
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature:

Description

PyModuleConfig::set_config() is meant to set a configuration option if a value is provided, and remove the option if no value is passed. The setting part works fine, the removing part, not so much. For example, if you run `ceph orchestrator set backend ''` to unset the orchestrator backend, the mgr/orchestrator_cli/orchestrator config option remains present, and the mgr log says:

2019-11-22T04:18:55.840+0100 7f2807c67700  0 mgr[py] `config set mgrmgr/orchestrator_cli/orchestrator --` failed: (22) Invalid argument
2019-11-22T04:18:55.840+0100 7f2807c67700  0 mgr[py] mon returned -22: unrecognized config target ''

Related issues

Copied to mgr - Backport #48768: nautilus: mgr/PyModule.cc: set_config with an empty value doesn't remove the config option Resolved

History

#1 Updated by Tim Serong over 1 year ago

  • Category set to ceph-mgr

#2 Updated by Tim Serong over 1 year ago

  • Status changed from New to Fix Under Review
  • Pull request ID set to 31807

#3 Updated by Sage Weil over 1 year ago

  • Status changed from Fix Under Review to Resolved

#4 Updated by Jason Dillaman about 2 months ago

  • Status changed from Resolved to Pending Backport
  • Backport set to nautilus

This bug still exists in the Nautilus branch

#5 Updated by Backport Bot about 2 months ago

  • Copied to Backport #48768: nautilus: mgr/PyModule.cc: set_config with an empty value doesn't remove the config option added

#6 Updated by Nathan Cutler about 2 months ago

  • Status changed from Pending Backport to Resolved

While running with --resolve-parent, the script "backport-create-issue" noticed that all backports of this issue are in status "Resolved" or "Rejected".

Also available in: Atom PDF