Project

General

Profile

Bug #42923

pybind / cephfs: remove static typing in LibCephFS.chown

Added by Venky Shankar 4 months ago. Updated 2 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Code Hygiene
Target version:
% Done:

0%

Source:
Community (dev)
Tags:
Backport:
nautilus
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
mgr/volumes
Labels (FS):
Pull request ID:
Crash signature:

Description

    def chown(self, path, int uid, int gid):
        """                                                                                                                           
        Change directory ownership                                                                                                    
        :param path: the path of the directory to change.                                                                             
        :param uid: the uid to set                                                                                                    
        :param gid: the gid to set                                                                                                    
        """ 
        self.require_state("mounted")
        path = cstr(path, 'path')
        if not isinstance(uid, int):
            raise TypeError('uid must be an int')
        elif not isinstance(gid, int):
            raise TypeError('gid must be an int')

although Cython supports typing function agrs, it makes less sense as the type is checked in the function itself. Plus, to be uniform with other cephfs python binding APIs, it makes sense to remove static typing here.


Related issues

Copied to fs - Backport #43085: nautilus: pybind / cephfs: remove static typing in LibCephFS.chown Resolved

History

#1 Updated by Venky Shankar 4 months ago

  • Category set to Code Hygiene
  • Status changed from New to In Progress
  • Assignee set to Venky Shankar
  • Target version set to v15.0.0
  • Start date deleted (11/21/2019)
  • Source set to Community (dev)
  • Tags set to nautilus
  • Component(FS) mgr/volumes added

#2 Updated by Venky Shankar 4 months ago

  • Status changed from In Progress to Fix Under Review
  • Pull request ID set to 31756

#3 Updated by Patrick Donnelly 4 months ago

  • Status changed from Fix Under Review to Pending Backport

#4 Updated by Nathan Cutler 4 months ago

  • Tags deleted (nautilus)
  • Backport set to nautilus

#5 Updated by Nathan Cutler 4 months ago

  • Copied to Backport #43085: nautilus: pybind / cephfs: remove static typing in LibCephFS.chown added

#6 Updated by Nathan Cutler 4 months ago

  • Status changed from Pending Backport to Resolved

#7 Updated by Nathan Cutler 4 months ago

  • Status changed from Resolved to Pending Backport

#8 Updated by Nathan Cutler 2 months ago

  • Status changed from Pending Backport to Resolved

While running with --resolve-parent, the script "backport-create-issue" noticed that all backports of this issue are in status "Resolved" or "Rejected".

Also available in: Atom PDF