Project

General

Profile

Bug #42791

functional tests only assume correct number is osds if branch tests is mimic or luminous

Added by Jan Fajerski 11 months ago. Updated 8 months ago.

Status:
Resolved
Priority:
Urgent
Assignee:
-
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
nautilus, mimic, luminous
Regression:
No
Severity:
2 - major
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature:

Description

This is not correct as we might test different branch names, that are based on mimic or luminous.
Results in

=================================== FAILURES ===================================
_________ TestOSDs.test_osds_listen_on_public_network[ansible://osd0] __________
[gw0] linux2 -- Python 2.7.5 /tmp/tox.dV8tW1s1S4/xenial-filestore-create/bin/python2.7

self = <tests.osd.test_osds.TestOSDs object at 0x7f95a7d56b10>
node = {'address': '192.168.3.100', 'cluster_address': '192.168.4.200', 'cluster_name': u'test', 'conf_path': '/etc/ceph/test.conf', ...}
host = <testinfra.host.Host object at 0x7f95a2354d10>

    def test_osds_listen_on_public_network(self, node, host):
        # TODO: figure out way to paramaterize this test
        nb_port = (node["num_osds"] * node["num_osd_ports"])
>       assert host.check_output(
            "netstat -lntp | grep ceph-osd | grep %s | wc -l" % (node["address"])) == str(nb_port)  # noqa E501
E       AssertionError: assert '6' == '12'
E         - 6
E         + 12

../../../../tests/osd/test_osds.py:12: AssertionError
_________ TestOSDs.test_osds_listen_on_cluster_network[ansible://osd0] _________
[gw3] linux2 -- Python 2.7.5 /tmp/tox.dV8tW1s1S4/xenial-filestore-create/bin/python2.7

self = <tests.osd.test_osds.TestOSDs object at 0x7f4fd3419550>
node = {'address': '192.168.3.100', 'cluster_address': '192.168.4.200', 'cluster_name': u'test', 'conf_path': '/etc/ceph/test.conf', ...}
host = <testinfra.host.Host object at 0x7f4fdce37ed0>

    def test_osds_listen_on_cluster_network(self, node, host):
        # TODO: figure out way to paramaterize this test
        nb_port = (node["num_osds"] * node["num_osd_ports"])
>       assert host.check_output("netstat -lntp | grep ceph-osd | grep %s | wc -l" %  # noqa E501
                                 (node["cluster_address"])) == str(nb_port)
E       AssertionError: assert '6' == '12'
E         - 6
E         + 12

../../../../tests/osd/test_osds.py:18: AssertionError

Related issues

Copied to ceph-volume - Backport #42800: nautilus: functional tests only assume correct number is osds if branch tests is mimic or luminous Resolved
Copied to ceph-volume - Backport #42801: mimic: functional tests only assume correct number is osds if branch tests is mimic or luminous Resolved
Copied to ceph-volume - Backport #43759: luminous: functional tests only assume correct number is osds if branch tests is mimic or luminous Resolved

History

#1 Updated by Jan Fajerski 11 months ago

  • Status changed from New to Fix Under Review
  • Backport set to nautilus, mimic
  • Pull request ID set to 31592

#2 Updated by Jan Fajerski 11 months ago

  • Priority changed from Normal to Urgent
  • Severity changed from 3 - minor to 2 - major

#3 Updated by Jan Fajerski 11 months ago

  • Status changed from Fix Under Review to Pending Backport

#4 Updated by Jan Fajerski 11 months ago

  • Copied to Backport #42800: nautilus: functional tests only assume correct number is osds if branch tests is mimic or luminous added

#5 Updated by Jan Fajerski 11 months ago

  • Copied to Backport #42801: mimic: functional tests only assume correct number is osds if branch tests is mimic or luminous added

#6 Updated by Jan Fajerski 8 months ago

  • Backport changed from nautilus, mimic to nautilus, mimic, luminous

#7 Updated by Jan Fajerski 8 months ago

  • Copied to Backport #43759: luminous: functional tests only assume correct number is osds if branch tests is mimic or luminous added

#8 Updated by Jan Fajerski 8 months ago

  • Status changed from Pending Backport to Resolved

Also available in: Atom PDF