Project

General

Profile

Bug #42718

Improve OSDMap::calc_pg_upmaps() efficiency

Added by David Zafman 5 months ago. Updated 2 months ago.

Status:
Resolved
Priority:
High
Assignee:
Category:
-
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
luminous, mimic, nautilus
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(RADOS):
Pull request ID:
Crash signature:

Description

We should eliminate the rules based pool sets being passed to calc_pg_upmaps()

Also, osdmaptool --upmap should be as similar to do_upmap() in the balancer module as possible


Related issues

Related to RADOS - Bug #42971: mgr hangs with upmap balancer New 11/22/2019
Related to Ceph - Bug #43084: std:random_shuffle is depricated in C++17 Resolved
Copied to RADOS - Backport #43092: nautilus: Improve OSDMap::calc_pg_upmaps() efficiency Resolved
Copied to RADOS - Backport #43093: luminous: Improve OSDMap::calc_pg_upmaps() efficiency Resolved
Copied to RADOS - Backport #43094: mimic: Improve OSDMap::calc_pg_upmaps() efficiency Resolved

History

#1 Updated by David Zafman 5 months ago

  • Backport set to luminous, mimic, nautilus
  • Pull request ID set to 31504

#2 Updated by David Zafman 4 months ago

The rules based pool groups being passed to calc_pg_upmaps() is a better method, so we don't want to revert.

try_pg_upmap() is failing frequently when it shouldn't be. The rule number needs to be passed to get_parent_of_type() so that the right crush handling happens. This is a majority of the performance problems.

#3 Updated by Josh Durgin 4 months ago

  • Related to Bug #42971: mgr hangs with upmap balancer added

#4 Updated by David Zafman 4 months ago

  • Pull request ID changed from 31504 to 31774

#5 Updated by David Zafman 4 months ago

  • Status changed from In Progress to Pending Backport

#6 Updated by David Zafman 4 months ago

  • Copied to Backport #43092: nautilus: Improve OSDMap::calc_pg_upmaps() efficiency added

#7 Updated by David Zafman 4 months ago

  • Copied to Backport #43093: luminous: Improve OSDMap::calc_pg_upmaps() efficiency added

#8 Updated by David Zafman 4 months ago

  • Copied to Backport #43094: mimic: Improve OSDMap::calc_pg_upmaps() efficiency added

#10 Updated by Nathan Cutler 4 months ago

  • Related to Bug #43084: std:random_shuffle is depricated in C++17 added

#11 Updated by David Zafman 2 months ago

  • Status changed from Pending Backport to Resolved

Also available in: Atom PDF