Project

General

Profile

Actions
Copy link

Bug #42718

closed

Improve OSDMap::calc_pg_upmaps() efficiency

Added by David Zafman over 4 years ago. Updated over 4 years ago.

Status:
Resolved
Priority:
High
Assignee:
David Zafman
Category:
-
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
luminous, mimic, nautilus
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(RADOS):
Pull request ID:
31774
Crash signature (v1):
Crash signature (v2):

Description

We should eliminate the rules based pool sets being passed to calc_pg_upmaps()

Also, osdmaptool --upmap should be as similar to do_upmap() in the balancer module as possible

Related issues 5 (1 open — 4 closed)

Related to RADOS - Bug #42971: mgr hangs with upmap balancerNewDavid Zafman11/22/2019

Actions
Related to Ceph - Bug #43084: std:random_shuffle is depricated in C++17ResolvedDavid Zafman

Actions
Copied to RADOS - Backport #43092: nautilus: Improve OSDMap::calc_pg_upmaps() efficiencyResolvedDavid ZafmanActions
Copied to RADOS - Backport #43093: luminous: Improve OSDMap::calc_pg_upmaps() efficiencyResolvedDavid ZafmanActions
Copied to RADOS - Backport #43094: mimic: Improve OSDMap::calc_pg_upmaps() efficiencyResolvedDavid ZafmanActions
Actions
Copy link
 #1

Updated by David Zafman over 4 years ago

  • Backport set to luminous, mimic, nautilus
  • Pull request ID set to 31504
Actions
Copy link
 #2

Updated by David Zafman over 4 years ago

The rules based pool groups being passed to calc_pg_upmaps() is a better method, so we don't want to revert.

try_pg_upmap() is failing frequently when it shouldn't be. The rule number needs to be passed to get_parent_of_type() so that the right crush handling happens. This is a majority of the performance problems.

Actions
Copy link
 #3

Updated by Josh Durgin over 4 years ago

  • Related to Bug #42971: mgr hangs with upmap balancer added
Actions
Copy link
 #4

Updated by David Zafman over 4 years ago

  • Pull request ID changed from 31504 to 31774
Actions
Copy link
 #5

Updated by David Zafman over 4 years ago

  • Status changed from In Progress to Pending Backport
Actions
Copy link
 #6

Updated by David Zafman over 4 years ago

  • Copied to Backport #43092: nautilus: Improve OSDMap::calc_pg_upmaps() efficiency added
Actions
Copy link
 #7

Updated by David Zafman over 4 years ago

  • Copied to Backport #43093: luminous: Improve OSDMap::calc_pg_upmaps() efficiency added
Actions
Copy link
 #8

Updated by David Zafman over 4 years ago

  • Copied to Backport #43094: mimic: Improve OSDMap::calc_pg_upmaps() efficiency added
Actions
Copy link
 #10

Updated by Nathan Cutler over 4 years ago

  • Related to Bug #43084: std:random_shuffle is depricated in C++17 added
Actions
Copy link
 #11

Updated by David Zafman over 4 years ago

  • Status changed from Pending Backport to Resolved
Actions
Copy link

Also available in: Atom PDF