Project

General

Profile

Feature #42638

Allow specifying pg_autoscale_mode when creating a new pool

Added by Kiefer Chang 8 months ago. Updated 5 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Administration/Usability
Target version:
% Done:

0%

Source:
Tags:
Backport:
Reviewed:
Affected Versions:
Component(RADOS):
ceph cli
Pull request ID:

Description

pg_autoscaler is enabled by default in Octopus, but we can't disable the feature when creating a new pool.
This might lead to a situation that the created pool has different pg from the value we specify.

Currently, there are two methods to adjust the pg_autoscale flags for pools:
  • Set the feature by pool. There is a window between this command and `osd create` command, pg_autoscaler might start its operation during this window:
    ceph osd pool set <pool-name> pg_autoscale_mode off
    
  • Turn off the feature globally, which might not be preferred either:
    ceph config set global osd_pool_default_pg_autoscale_mode off
    

It would be nice if we can specify the mode during pool creation. This also helps Dashboard to have better control on new-created pools.


Related issues

Related to mgr - Bug #42608: mgr/dashboard: dashboard e2e Jenkins job failures when editing placement groups Resolved 11/04/2019
Related to mgr - Feature #38227: mgr/dashboard: Manage PG autoscaling Resolved 02/07/2019

History

#1 Updated by Kiefer Chang 8 months ago

  • Related to Feature #41005: mgr/dashboard: Suggest enabling newly supported features added

#2 Updated by Kiefer Chang 8 months ago

  • Related to deleted (Feature #41005: mgr/dashboard: Suggest enabling newly supported features)

#3 Updated by Kiefer Chang 8 months ago

  • Related to Bug #42608: mgr/dashboard: dashboard e2e Jenkins job failures when editing placement groups added

#4 Updated by Kiefer Chang 8 months ago

  • Related to Feature #38227: mgr/dashboard: Manage PG autoscaling added

#5 Updated by Patrick Seidensal 7 months ago

  • Blocks Fix #43102: mgr/dashboard: remove E2E test workaround for autoscaler added

#6 Updated by Stephan Müller 6 months ago

I really think this issue should be closed.
I tested with the autoscaler globally set to on. Tested the pool creation with the autoscaler setting to on and off and if set to off the autoscaler doesn't seem to change the pool after a while, like it does if left on "on".

I didn't test setting the autoscaler globally to "off" and use it in the pool form - ATM I'm not sure this would work. But if so, this would be an issue on it's own.

#7 Updated by Stephan Müller 6 months ago

  • Blocks deleted (Fix #43102: mgr/dashboard: remove E2E test workaround for autoscaler)

#8 Updated by Stephan Müller 6 months ago

  • Related to Fix #43102: mgr/dashboard: remove E2E test workaround for autoscaler added

#9 Updated by Stephan Müller 6 months ago

  • Related to deleted (Fix #43102: mgr/dashboard: remove E2E test workaround for autoscaler)

#10 Updated by Neha Ojha 5 months ago

  • Status changed from New to Fix Under Review
  • Pull request ID set to 33092

#11 Updated by Lenz Grimmer 5 months ago

  • Tags set to usability
  • Assignee set to Sage Weil
  • Target version set to v15.0.0

#12 Updated by Sage Weil 5 months ago

  • Status changed from Fix Under Review to Resolved

Also available in: Atom PDF