Project

General

Profile

Bug #42602

client: missing const SEEK_DATA and SEEK_HOLE on ALPINE LINUX

Added by Stefan Bischoff 11 months ago. Updated 7 months ago.

Status:
Resolved
Priority:
Normal
Category:
Correctness/Safety
Target version:
% Done:

0%

Source:
Community (dev)
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
Client
Labels (FS):
Pull request ID:
Crash signature:

Description

The non-posix conform constants SEEK_DATA and SEEK_HOLE are missin on alpine linux / musllib. So you cant compile src/client/Client.cc there. Maybe one can add some #ifndef blocks. not sure wheater this would break functionality.

10-client.patch View (477 Bytes) Stefan Bischoff, 11/03/2019 10:32 PM


Related issues

Related to fs - Bug #42107: client: no method to handle SEEK_HOLE and SEEK_DATA in lseek Resolved

History

#1 Updated by Greg Farnum 10 months ago

  • Project changed from Ceph to fs
  • Category changed from build to Correctness/Safety
  • Component(FS) Client added

#2 Updated by Patrick Donnelly 10 months ago

  • Related to Bug #42107: client: no method to handle SEEK_HOLE and SEEK_DATA in lseek added

#3 Updated by Patrick Donnelly 10 months ago

  • Subject changed from Missing const SEEK_DATA and SEEK_HOLE on ALPINE LINUX to client: missing const SEEK_DATA and SEEK_HOLE on ALPINE LINUX

Better would be to wrap the usage of SEEK_DATA/SEEK_HOLE in #ifdefs. Would you like to submit a PR?

#4 Updated by Stefan Bischoff 10 months ago

Patrick Donnelly wrote:

Better would be to wrap the usage of SEEK_DATA/SEEK_HOLE in #ifdefs. Would you like to submit a PR?

Here you go: https://github.com/ceph/ceph/pull/31568

#5 Updated by Patrick Donnelly 10 months ago

  • Status changed from New to Fix Under Review
  • Assignee set to Stefan Bischoff
  • Start date deleted (11/03/2019)
  • Pull request ID set to 31568
  • Affected Versions deleted (v15.0.0)

#6 Updated by Patrick Donnelly 7 months ago

  • Status changed from Fix Under Review to Resolved

Also available in: Atom PDF