Fix #42508: cephfs-shell: print a helpful message instead of a Python backtrace when no config file has been found - CephFS - Ceph

Actions

Copy link

Fix #42508

closed

cephfs-shell: print a helpful message instead of a Python backtrace when no config file has been found

Added by Lenz Grimmer over 4 years ago. Updated over 4 years ago.

Status:

Resolved

Priority:

Normal

Assignee:

Rishabh Dave

Category:

Administration/Usability

Target version:

Ceph - v15.0.0

% Done:

Source:

Development

Tags:

Backport:

Reviewed:

Affected Versions:

Ceph - v14.2.4

ceph-qa-suite:

Component(FS):

cephfs-shell

Labels (FS):

task(easy)

Pull request ID:

31460

Crash signature (v1):

Crash signature (v2):

Description

Currently, running cephfs-shell on a blank system without any configuration file fails with a Python backtrace:

cephfs-shell       
Traceback (most recent call last):
  File "/usr/bin/cephfs-shell", line 1268, in <module>
    setup_cephfs(config_file)
  File "/usr/bin/cephfs-shell", line 66, in setup_cephfs
    cephfs = libcephfs.LibCephFS(conffile=config_file)
  File "cephfs.pyx", line 419, in cephfs.LibCephFS.__cinit__
  File "cephfs.pyx", line 457, in cephfs.LibCephFS.create
  File "cephfs.pyx", line 474, in cephfs.LibCephFS.conf_read_file
cephfs.ObjectNotFound: [Errno 2] error calling conf_read_file

It would be nice if the tool would print out a more helpful/meaningful error message, e.g. "Config file <file> not found."

Actions

Copy link

Updated by Patrick Donnelly over 4 years ago

Subject changed from fs/cephfs-shell: cephfs-shell should print a helpful message instead of a Python backtrace when no config file has been found to cephfs-shell: print a helpful message instead of a Python backtrace when no config file has been found
Assignee set to Rishabh Dave
Target version set to v15.0.0
Start date deleted (~~10/28/2019~~)
Source set to Development