Project

General

Profile

Actions
Copy link

Bug #42485

closed

verify_upmaps can not cancel invalid upmap_items in some cases

Added by huang jun over 4 years ago. Updated over 4 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
luminous,mimic,nautilus
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(RADOS):
Pull request ID:
31131
Crash signature (v1):
Crash signature (v2):

Description

We can not cancel in verify_upmap if remap an osd to different root bucket,

cluster topology:
osd.0 ~ osd.29 belongs to datacenter 1
osd30 ~ osd.59 belongs to datacenter 2
crush rule:
take datacenter 1
chooseleaf 2 host
emit
take datacenter 2
chooseleaf 2 host
emit
The pg's primary osd in datacenter 1.

We should cancel the pgid from upmap_items like below

from [26,12,54,46] to [30,12,54,46]
pg_upmap_items [26,30]

from [16,25,53,31] to [40,25,53,0]
pg_upmap_items [16,20,31,0]

Related issues 3 (0 open — 3 closed)

Copied to RADOS - Backport #42546: mimic: verify_upmaps can not cancel invalid upmap_items in some casesRejectedDavid ZafmanActions
Copied to RADOS - Backport #42547: nautilus: verify_upmaps can not cancel invalid upmap_items in some casesResolvedNathan CutlerActions
Copied to RADOS - Backport #42548: luminous: verify_upmaps can not cancel invalid upmap_items in some casesResolvedNathan CutlerActions
Actions
Copy link
 #1

Updated by xie xingguo over 4 years ago

  • Backport set to luminous,mimic,nautilus
Actions
Copy link
 #2

Updated by Sage Weil over 4 years ago

  • Status changed from New to Pending Backport
Actions
Copy link
 #3

Updated by Nathan Cutler over 4 years ago

  • Copied to Backport #42546: mimic: verify_upmaps can not cancel invalid upmap_items in some cases added
Actions
Copy link
 #4

Updated by Nathan Cutler over 4 years ago

  • Copied to Backport #42547: nautilus: verify_upmaps can not cancel invalid upmap_items in some cases added
Actions
Copy link
 #5

Updated by Nathan Cutler over 4 years ago

  • Copied to Backport #42548: luminous: verify_upmaps can not cancel invalid upmap_items in some cases added
Actions
Copy link
 #6

Updated by David Zafman over 4 years ago

  • Status changed from Pending Backport to Resolved
Actions
Copy link
 #7

Updated by Nathan Cutler over 4 years ago

NOTE: https://github.com/ceph/ceph/pull/31131 was merged to master and backported to nautilus and luminous, before it was found to be problematic, and needed to be reverted.

For nautilus, both the backport and its revert were merged for 14.2.5.

For luminous, both the backport and its revert were merged for 12.2.13.

For mimic, no backport was undertaken.

Actions
Copy link

Also available in: Atom PDF