https://tracker.ceph.com/
https://tracker.ceph.com/favicon.ico
2019-10-28T21:06:47Z
Ceph
CephFS - Bug #42467: mds: daemon crashes while updating blacklist
https://tracker.ceph.com/issues/42467?journal_id=149737
2019-10-28T21:06:47Z
Greg Farnum
gfarnum@redhat.com
<ul><li><strong>Project</strong> changed from <i>Ceph</i> to <i>CephFS</i></li></ul>
CephFS - Bug #42467: mds: daemon crashes while updating blacklist
https://tracker.ceph.com/issues/42467?journal_id=149745
2019-10-28T22:00:34Z
Patrick Donnelly
pdonnell@redhat.com
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/149745/diff?detail_id=152480">diff</a>)</li><li><strong>Target version</strong> deleted (<del><i>v14.2.5</i></del>)</li><li><strong>Start date</strong> deleted (<del><i>10/24/2019</i></del>)</li><li><strong>Source</strong> set to <i>Community (user)</i></li><li><strong>Affected Versions</strong> <i>v14.2.5</i> added</li><li><strong>Component(FS)</strong> <i>MDS</i> added</li><li><strong>Labels (FS)</strong> <i>crash</i> added</li></ul>
CephFS - Bug #42467: mds: daemon crashes while updating blacklist
https://tracker.ceph.com/issues/42467?journal_id=149812
2019-10-29T13:52:23Z
Patrick Donnelly
pdonnell@redhat.com
<ul><li><strong>Subject</strong> changed from <i>MDS daemon crashes</i> to <i>mds: daemon crashes while updating blacklist</i></li><li><strong>Assignee</strong> set to <i>Patrick Donnelly</i></li></ul>
CephFS - Bug #42467: mds: daemon crashes while updating blacklist
https://tracker.ceph.com/issues/42467?journal_id=155853
2020-01-15T19:39:27Z
Patrick Donnelly
pdonnell@redhat.com
<ul><li><strong>Assignee</strong> changed from <i>Patrick Donnelly</i> to <i>Zheng Yan</i></li><li><strong>Target version</strong> set to <i>v15.0.0</i></li><li><strong>Backport</strong> set to <i>nautilus,mimic</i></li></ul><p>Zheng, I think you may have inadvertently fixed this in</p>
<pre>
commit a10f051af25640def2ca6132de42693975de5ba1 HEAD
Author: Yan, Zheng <zyan@redhat.com>
Date: Mon Sep 30 14:20:17 2019 +0800
mds: cleanup code that kills session requests
Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
---
src/mds/Server.cc | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/src/mds/Server.cc b/src/mds/Server.cc
index af48d93a3ec..4012a13b2bd 100644
--- a/src/mds/Server.cc
+++ b/src/mds/Server.cc
@@ -1234,11 +1234,8 @@ void Server::journal_close_session(Session *session, int state, Context *on_safe
mdlog->flush();
// clean up requests, too
- elist<MDRequestImpl*>::iterator p =
- session->requests.begin(member_offset(MDRequestImpl,
- item_session_request));
- while (!p.end()) {
- MDRequestRef mdr = mdcache->request_get((*p)->reqid);
+ for (auto p = session->requests.begin(); !p.end(); ) {
+ MDRequestRef mdr(*p);
++p;
mdcache->request_kill(mdr);
}
</pre>
<p>But I'm not sure if it's normal for a request to not be in the `MDCache::active_requests`. Does it make sense?</p>
CephFS - Bug #42467: mds: daemon crashes while updating blacklist
https://tracker.ceph.com/issues/42467?journal_id=156467
2020-01-21T15:04:05Z
Zheng Yan
ukernel@gmail.com
<ul></ul><p>No idea how this happen. when a request is removed from active_requests, request should also be removed from session->requests</p>
CephFS - Bug #42467: mds: daemon crashes while updating blacklist
https://tracker.ceph.com/issues/42467?journal_id=156486
2020-01-21T17:06:52Z
Patrick Donnelly
pdonnell@redhat.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Can't reproduce</i></li><li><strong>Target version</strong> deleted (<del><i>v15.0.0</i></del>)</li><li><strong>Backport</strong> deleted (<del><i>nautilus,mimic</i></del>)</li></ul>
CephFS - Bug #42467: mds: daemon crashes while updating blacklist
https://tracker.ceph.com/issues/42467?journal_id=158644
2020-02-13T17:30:04Z
Patrick Donnelly
pdonnell@redhat.com
<ul><li><strong>Status</strong> changed from <i>Can't reproduce</i> to <i>New</i></li><li><strong>Priority</strong> changed from <i>Normal</i> to <i>High</i></li><li><strong>Affected Versions</strong> <i>v13.2.8</i> added</li></ul><p>A new report of this coming from ceph-users:</p>
<p>"[ceph-users] Ceph MDS ASSERT In function 'MDRequestRef'"</p>
<p>Different trace:</p>
<pre>
-10001> 2020-02-13 17:42:35.543 7f11b5669700 -1 /build/ceph-13.2.8/src/mds/MDCache.cc: In function 'MDRequestRef MDCa
che::request_get(metareqid_t)' thread 7f11b5669700 time 2020-02-13 17:42:35.545815
/build/ceph-13.2.8/src/mds/MDCache.cc: 9523: FAILED assert(p != active_requests.end())
ceph version 13.2.8 (5579a94fafbc1f9cc913a0f5d362953a5d9c3ae0) mimic (stable)
1: (ceph::__ceph_assert_fail(char const*, char const*, int, char const*)+0x14e) [0x7f11bd8e69de]
2: (()+0x287b67) [0x7f11bd8e6b67]
3: (MDCache::request_get(metareqid_t)+0x94) [0x560cde8bb214]
4: (Server::journal_close_session(Session*, int, Context*)+0x9dd) [0x560cde829d1d]
5: (Server::handle_client_session(MClientSession*)+0x1071) [0x560cde82b0f1]
6: (Server::dispatch(Message*)+0x30b) [0x560cde86f87b]
7: (MDSRank::handle_deferrable_message(Message*)+0x434) [0x560cde7e1664]
8: (MDSRank::_dispatch(Message*, bool)+0x89b) [0x560cde7f8c7b]
9: (MDSRankDispatcher::ms_dispatch(Message*)+0xa3) [0x560cde7f92e3]
10: (MDSDaemon::ms_dispatch(Message*)+0xd3) [0x560cde7d92b3]
11: (DispatchQueue::entry()+0xb92) [0x7f11bd9a9e52]
12: (DispatchQueue::DispatchThread::entry()+0xd) [0x7f11bda46e2d]
13: (()+0x76db) [0x7f11bd1d76db]
14: (clone()+0x3f) [0x7f11bc3bd88f]
</pre>
CephFS - Bug #42467: mds: daemon crashes while updating blacklist
https://tracker.ceph.com/issues/42467?journal_id=158681
2020-02-13T22:35:28Z
Stefan Kooman
ceph@kooman.org
<ul></ul><p>ceph-post-file: 44655e58-39e0-4fff-a2fc-2645b131c594 for the crash listed above (13.2.8)</p>
CephFS - Bug #42467: mds: daemon crashes while updating blacklist
https://tracker.ceph.com/issues/42467?journal_id=161470
2020-03-23T12:16:18Z
Zheng Yan
ukernel@gmail.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Fix Under Review</i></li><li><strong>Pull request ID</strong> set to <i>33570</i></li></ul>
CephFS - Bug #42467: mds: daemon crashes while updating blacklist
https://tracker.ceph.com/issues/42467?journal_id=161941
2020-03-30T09:09:26Z
Zheng Yan
ukernel@gmail.com
<ul><li><strong>Status</strong> changed from <i>Fix Under Review</i> to <i>Duplicate</i></li></ul><p>dup of <a class="issue tracker-1 status-3 priority-5 priority-high3 closed" title="Bug: mds: assert(p != active_requests.end()) (Resolved)" href="https://tracker.ceph.com/issues/44316">#44316</a></p>