https://tracker.ceph.com/https://tracker.ceph.com/favicon.ico2013-02-22T09:36:07ZCeph rbd - Bug #4238: krbd: still more barrier fixeshttps://tracker.ceph.com/issues/4238?journal_id=177342013-02-22T09:36:07ZAlex Elderelder@ieee.org
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Fix Under Review</i></li><li><strong>Target version</strong> set to <i>v0.58</i></li></ul><p>Posted for review.<br /><pre>
commit 5ba6ae1682d395087cf854dc7dd8a4c72419b47b
Author: Alex Elder <elder@inktank.com>
Date: Thu Feb 21 10:10:06 2013 -0600
rbd: barriers are hard
Let's go shopping!
I'm afraid this may not have gotten it right:
07741308 rbd: add barriers near done flag operations
The smp_wmb() should have been done *before* setting the done flag,
to ensure all other data was valid before marking the object request
done.
Switch to use atomic_inc_return() here to set the done flag, which
allows us to verify we don't mark something done more than once.
Doing this also implies general barriers before and after the call.
And although a read memory barrier might have been sufficient before
reading the done flag, convert this to a full memory barrier just
to put this issue to bed.
This resolves:
http://tracker.ceph.com/issues/4238
Signed-off-by: Alex Elder <elder@inktank.com>
</pre></p> rbd - Bug #4238: krbd: still more barrier fixeshttps://tracker.ceph.com/issues/4238?journal_id=178992013-02-25T19:11:50ZAlex Elderelder@ieee.org
<ul><li><strong>Status</strong> changed from <i>Fix Under Review</i> to <i>Resolved</i></li></ul><p>This has been committed.</p>
<p>commit 632b88cadece050ca925d74bda250c4a320c5cc7<br />Author: Alex Elder <<a class="email" href="mailto:elder@inktank.com">elder@inktank.com</a>><br />Date: Thu Feb 21 10:10:06 2013 -0600</p>
<pre><code>rbd: barriers are hard</code></pre>