Project

General

Profile

Cleanup #4234

libceph: encapsulate flag setting

Added by Alex Elder about 7 years ago. Updated about 7 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Target version:
% Done:

0%

Tags:
Backport:
Reviewed:
Affected Versions:
Pull request ID:

Description

While working on http://tracker.ceph.com/issues/4079 I created
some helper routines to wrap around the code that tests, sets,
and clears messenger flags. It made it easier to experiment
with the effect of adding barriers. Regardless, they nicely
abstract the flags though, so they might as well go in.

History

#1 Updated by Alex Elder about 7 years ago

  • Status changed from New to In Progress

Forgot to indicate this was underway.

#2 Updated by Alex Elder about 7 years ago

  • Status changed from In Progress to 4
  • Target version set to v0.58

Posted for review. (Marked this as "Feedback" because
I can't mark a cleanup issue "need review")

commit 6636358493749c34d9d2ce40789a47aa8d7912b1
Author: Alex Elder <elder@inktank.com>
Date:   Wed Feb 20 10:25:12 2013 -0600

    libceph: define connection flag helpers

    Define and use functions that encapsulate operations performed on
    a connection's flags.

    This resolves:
        http://tracker.ceph.com/issues/4234

    Signed-off-by: Alex Elder <elder@inktank.com>

#3 Updated by Alex Elder about 7 years ago

  • Status changed from 4 to Resolved

This has been committed.

commit c9ffc77adebf9dfe3026ede6c8b3c61586b485b7
Author: Alex Elder <>
Date: Wed Feb 20 10:25:12 2013 -0600

libceph: define connection flag helpers
Define and use functions that encapsulate operations performed on
a connection's flags.
This resolves:
http://tracker.ceph.com/issues/4234
Signed-off-by: Alex Elder &lt;&gt;
Reviewed-by: Josh Durgin &lt;&gt;

Also available in: Atom PDF