Project

General

Profile

Actions
Copy link

Feature #42308

open

Cleanup #42304: mgr/dashboard: alerts and silences pages improvements

mgr/dashboard: editing silence: editing matcher: hint is only shown for non-regular expressions

Added by Patrick Seidensal over 4 years ago. Updated about 3 years ago.

Status:
In Progress
Priority:
Normal
Assignee:
Nizamudeen A
Category:
Monitoring
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
Reviewed:
Affected Versions:
Ceph - v15.0.0
Pull request ID:

Description

When editing a matcher on the `Edit Silence` form of the `Silences` page, a message is shown:

Your matcher seems to match no currently defined rule or active alert.

This message disappears when the `Use regular expression` checkbox is checked.

Is that a bug?

Files

Download all files
edit_matcher_regexp.png (25.6 KB) edit_matcher_regexp.png Patrick Seidensal, 10/14/2019 03:59 PM
edit_matcher_value.png (32.6 KB) edit_matcher_value.png Patrick Seidensal, 10/14/2019 03:59 PM
Actions
Copy link
 #1

Updated by Nizamudeen A about 4 years ago

  • Status changed from New to In Progress
  • Assignee set to Nizamudeen A
Actions
Copy link
 #2

Updated by Stephan Müller about 4 years ago

  • Tracker changed from Bug to Feature

This is a missing feature not a bug. As the form doesn't even try to match something with the regex given. No text is shown in that case as if you would have removed the check text would be shown like that it can not match an active alert or it can match an active alert.

This means there are three states of texts:
  • it matches
  • it doesn't matches
  • don't know (no text)

The new feature to match the regex would reduce the text state to two.

You have also two make sure that the regex given is understandable by the alertmanager of prometheus.

Make sure two point out what's wrong with the regex in order to match the allowed regex. I'm not sure which standard is supported so please look it up and provide a link in the help text if it doesn't match the right standard.

Actions
Copy link
 #3

Updated by Nizamudeen A about 4 years ago

Stephan Müller wrote:

This is a missing feature not a bug. As the form doesn't even try to match something with the regex given. No text is shown in that case as if you would have removed the check text would be shown like that it can not match an active alert or it can match an active alert.

This means there are three states of texts:
  • it matches
  • it doesn't matches
  • don't know (no text)

The new feature to match the regex would reduce the text state to two.

You have also two make sure that the regex given is understandable by the alertmanager of prometheus.

Make sure two point out what's wrong with the regex in order to match the allowed regex. I'm not sure which standard is supported so please look it up and provide a link in the help text if it doesn't match the right standard.

Thank you. I will look into this more and will be in touch with you if I have any doubts.

Actions
Copy link

Also available in: Atom PDF