Project

General

Profile

Actions
Copy link

Bug #42179

closed

mgr/dashboard: the cross sign button for some modals doesn't work

Added by Kiefer Chang over 4 years ago. Updated about 3 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Ricardo Marques
Category:
UI
Target version:
Ceph - v15.0.0
% Done:

0%

Source:
Tags:
low-hanging-fruit
Backport:
nautilus
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
Ceph - v14.2.5, Ceph - v15.0.0
ceph-qa-suite:
Pull request ID:
31783
Crash signature (v1):
Crash signature (v2):

Description

In some modal, the cross-sign button at the upper right side doesn't close the modal.

Example: the confirm modal for moving an image to trash
  • Create a pool with rbd application
  • Create an image on that pool
  • Move the image to trash, a modal will be displayed. The upper-right cross sign button doesn't work.

This should be fixed by providing modalRef to <cd-modal> tag (https://github.com/ceph/ceph/blob/c2adfb62c62fb742529f6eb3bf9bccc13dd4efed/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/rbd-trash-move-modal/rbd-trash-move-modal.component.html#L1):

<cd-modal>
to 
<cd-modal [modalRef]="modalRef">

Components might be affected (grep with <cd-modal> tag):

# grep '<cd-modal>' * -R
ceph/block/iscsi-target-image-settings-modal/iscsi-target-image-settings-modal.component.html:<cd-modal>
ceph/block/iscsi-target-iqn-settings-modal/iscsi-target-iqn-settings-modal.component.html:<cd-modal>
ceph/block/mirroring/pool-edit-mode-modal/pool-edit-mode-modal.component.html:<cd-modal>
ceph/block/mirroring/pool-edit-peer-modal/pool-edit-peer-modal.component.html:<cd-modal>
ceph/block/rbd-trash-move-modal/rbd-trash-move-modal.component.html:<cd-modal>
ceph/block/rbd-trash-purge-modal/rbd-trash-purge-modal.component.html:<cd-modal>
ceph/block/rbd-trash-restore-modal/rbd-trash-restore-modal.component.html:<cd-modal>

Files

modal.png (24.3 KB) modal.png Kiefer Chang, 10/04/2019 08:19 AM

Related issues 1 (0 open — 1 closed)

Copied to Dashboard - Backport #43123: mgr/dashboard: the cross sign button for some modals doesn't workResolvedAlfonso MartínezActions
Actions
Copy link
 #1

Updated by Ricardo Marques over 4 years ago

Actions
Copy link
 #2

Updated by Ricardo Marques over 4 years ago

  • Tags set to low-hanging-fruit
Actions
Copy link
 #3

Updated by Ricardo Marques over 4 years ago

  • Status changed from New to In Progress
  • Assignee set to Ricardo Marques
Actions
Copy link
 #4

Updated by Ricardo Marques over 4 years ago

  • Status changed from In Progress to Fix Under Review
  • Pull request ID set to 31783
Actions
Copy link
 #5

Updated by Lenz Grimmer over 4 years ago

  • Status changed from Fix Under Review to Resolved
Actions
Copy link
 #6

Updated by Alfonso Martínez over 4 years ago

  • Status changed from Resolved to Pending Backport
  • Backport set to nautilus
Actions
Copy link
 #7

Updated by Alfonso Martínez over 4 years ago

  • Copied to Backport #43123: mgr/dashboard: the cross sign button for some modals doesn't work added
Actions
Copy link
 #8

Updated by Nathan Cutler about 4 years ago

  • Status changed from Pending Backport to Resolved

While running with --resolve-parent, the script "backport-create-issue" noticed that all backports of this issue are in status "Resolved" or "Rejected".

Actions
Copy link
 #9

Updated by Ernesto Puerta about 3 years ago

  • Project changed from mgr to Dashboard
  • Category changed from 165 to UI
Actions
Copy link

Also available in: Atom PDF